Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboardjs - The Trezor icon cannot be seen with Dark mode enabled #2374

Closed
francovenica opened this issue Aug 9, 2023 · 0 comments · Fixed by #2392
Closed

Onboardjs - The Trezor icon cannot be seen with Dark mode enabled #2374

francovenica opened this issue Aug 9, 2023 · 0 comments · Fixed by #2392
Assignees
@katspaugh
Labels
minor Minor bug

Comments

@francovenica
Copy link
Contributor

Bug description

The icon becomes invisible in dark mode

Environment

  • Browser: Chrome
  • Wallet: any
  • Chain: any
  • Env: Current prod 1.15.2

Steps to reproduce

  1. Switch to dark mode in a safe settings page
  2. Open the modal in ETH network

Expected result

Trezor icon visible

Obtained result

Trezor icon invisible (possible white with white background)

Screenshots

image
@francovenica francovenica added bug minor Minor bug labels Aug 9, 2023
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Aug 9, 2023
@katspaugh katspaugh moved this from New issues to Todo in Safe{Wallet} Aug 14, 2023
@katspaugh katspaugh self-assigned this Aug 14, 2023
@katspaugh katspaugh moved this from Todo to In Progress in Safe{Wallet} Aug 14, 2023
@katspaugh katspaugh mentioned this issue Aug 14, 2023
Merged
@katspaugh katspaugh moved this from In Progress to Peer Review in Safe{Wallet} Aug 14, 2023
@katspaugh katspaugh moved this from Peer Review to Ready for QA in Safe{Wallet} Aug 14, 2023
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Aug 14, 2023
@francovenica francovenica moved this from QA in progress to In Progress in Safe{Wallet} Aug 14, 2023
@katspaugh katspaugh moved this from In Progress to Ready for QA in Safe{Wallet} Aug 15, 2023
@francovenica francovenica moved this from Ready for QA to QA done in Safe{Wallet} Aug 15, 2023
@github-project-automation github-project-automation bot moved this from QA done to Done in Safe{Wallet} Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katspaugh katspaugh

Labels
minor Minor bug
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: wallet icons in dark mode safe-global/safe-wallet-monorepo
2 participants
@katspaugh @francovenica