Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known addresses in ABI and multisend details #2422

Closed
katspaugh opened this issue Aug 21, 2023 · 0 comments · Fixed by #2423
Closed

Known addresses in ABI and multisend details #2422

katspaugh opened this issue Aug 21, 2023 · 0 comments · Fixed by #2423
Assignees
@katspaugh

Comments

@katspaugh
Copy link
Member

If a transaction contains "known addresses" (Ethereum addresses with a name and icon) in tx details, we should display the corresponding name and icon.

E.g. a Safe upgrade tx: https://app.safe.global/transactions/tx?id=multisig_0x85C9f5aA0F82A531087a356a55623Cf05E7Bb895_0xfe4f694a9264c4b8454c1f0191af0515d03e344b4267fc221ba3e8543be4616f&safe=eth:0x85C9f5aA0F82A531087a356a55623Cf05E7Bb895

Screenshot 2023-08-21 at 12 31 36

☝️ the 1.3.0 singleton and fallback handler have a name coming from the backend but it's not displayed.
@katspaugh katspaugh self-assigned this Aug 21, 2023
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Aug 21, 2023
@katspaugh katspaugh moved this from New issues to In Progress in Safe{Wallet} Aug 21, 2023
@katspaugh katspaugh mentioned this issue Aug 21, 2023
Merged
@katspaugh katspaugh moved this from In Progress to Peer Review in Safe{Wallet} Aug 21, 2023
@katspaugh katspaugh moved this from Peer Review to Ready for QA in Safe{Wallet} Aug 21, 2023
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Aug 22, 2023
@francovenica francovenica moved this from QA in progress to QA done in Safe{Wallet} Aug 23, 2023
@github-project-automation github-project-automation bot moved this from QA done to Done in Safe{Wallet} Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katspaugh katspaugh

Labels
None yet
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: show known addresses in decoded tx data safe-global/safe-wallet-monorepo
1 participant
@katspaugh