Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thousand separators to review amount #705

Closed
iamacook opened this issue May 3, 2022 · 2 comments · Fixed by #1265
Closed

Add thousand separators to review amount #705

iamacook opened this issue May 3, 2022 · 2 comments · Fixed by #1265
Assignees
@DiogoSoaress
Labels
enhancement New feature or request

Comments

@iamacook
Copy link
Member

iamacook commented May 3, 2022 •
edited
Loading

Overview

Large amounts on the review modal can be confusing. As such, we should add thousand separators.

Requirements

Format token amount in review modal header.

Screenshot

image
image
@iamacook iamacook transferred this issue from 5afe/safe-react Sep 28, 2022
@iamacook iamacook added the enhancement New feature or request label Sep 28, 2022
@schmanu schmanu moved this to Todo in Safe{Wallet} Nov 17, 2022
@DiogoSoaress DiogoSoaress moved this from Todo to In Progress in Safe{Wallet} Nov 24, 2022
@DiogoSoaress DiogoSoaress moved this from In Progress to Todo in Safe{Wallet} Nov 24, 2022
@DiogoSoaress DiogoSoaress moved this from Todo to In Progress in Safe{Wallet} Nov 24, 2022
@DiogoSoaress DiogoSoaress self-assigned this Nov 24, 2022
@DiogoSoaress DiogoSoaress moved this from In Progress to Todo in Safe{Wallet} Nov 28, 2022
@iamacook iamacook moved this from Todo to In Progress in Safe{Wallet} Nov 28, 2022
@DiogoSoaress DiogoSoaress mentioned this issue Nov 28, 2022
Merged
@DiogoSoaress DiogoSoaress moved this from In Progress to Peer Review in Safe{Wallet} Nov 28, 2022
@DiogoSoaress DiogoSoaress moved this from Peer Review to In Progress in Safe{Wallet} Dec 7, 2022
@DiogoSoaress DiogoSoaress moved this from In Progress to Peer Review in Safe{Wallet} Dec 7, 2022
@DiogoSoaress DiogoSoaress moved this from Peer Review to In Progress in Safe{Wallet} Dec 7, 2022
Repository owner moved this from In Progress to Done in Safe{Wallet} Dec 8, 2022
@DiogoSoaress DiogoSoaress moved this from Done to Ready for QA in Safe{Wallet} Dec 8, 2022
@DiogoSoaress
Copy link
Member

@safe-global/safe-qa sorry I've merged this by accident (didn't mean to skip QA) so I moved the ticket back to "Ready for QA".

@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Safe{Wallet} Dec 13, 2022
@liliya-soroka
Copy link
Member

Verified.
Only already opened bug is found with another separator when max option is used in the amount field

@liliya-soroka liliya-soroka moved this from QA in progress to QA done in Safe{Wallet} Dec 13, 2022
@DiogoSoaress DiogoSoaress moved this from QA done to Done in Safe{Wallet} Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiogoSoaress DiogoSoaress

Labels
enhancement New feature or request
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix format amount review modal safe-global/safe-wallet-monorepo
3 participants
@liliya-soroka @iamacook @DiogoSoaress