Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to the 'add owner' screen #2381

Closed
DmitryBespalov opened this issue Aug 10, 2023 · 0 comments · Fixed by #2399
Closed

Linking to the 'add owner' screen #2381

DmitryBespalov opened this issue Aug 10, 2023 · 0 comments · Fixed by #2399
Assignees

Comments

@DmitryBespalov
Copy link

DmitryBespalov commented Aug 10, 2023

As a new safe member,
I want to be added to the safe,
So that I could start using it.

As a safe owner,
I want to add new member to the owners list,
So that they could start using it.

Overview:

  • Mobile app provides a way for new owners to join existing safe. In short, it works like this:
    • To-be-added owner shares a link with the safe owner
    • Safe owner opens link and adds a new owner or replaces existing owner with the address from the link
  • Those links used to be supported before rewrite of the web ui
  • This functionality is used by ~10% of mobile users

URI pattern:

 {web app}/{chain prefix}:{safe address}/addOwner?address={new owner address}

Example of a link

https://app.safe.global/gor:0xabcdEEeEeEeEeEeEeEeEabCdEeeEEEEEEEeeEEeE/addOwner?address=0xaABCdeeEeeeeeeeeEeEEEABcdeEEeEeeEEEEeeEe

At present, such links lead to nowhere, and there's no way to link to the existing "add owner" or "replace owner" transaction modal.

The link is generated by the mobile app.

Original issue: safe-global/safe-ios#3096

@DmitryBespalov DmitryBespalov converted this from a draft issue Aug 10, 2023
@katspaugh katspaugh moved this from New issues to Todo in Web Squad Aug 14, 2023
@usame-algan usame-algan moved this from Todo to In Progress in Web Squad Aug 14, 2023
@usame-algan usame-algan self-assigned this Aug 14, 2023
@usame-algan usame-algan moved this from In Progress to Peer Review in Web Squad Aug 15, 2023
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Web Squad Aug 15, 2023
@francovenica francovenica moved this from Ready for QA to QA in progress in Web Squad Aug 15, 2023
@francovenica francovenica moved this from QA in progress to In Progress in Web Squad Aug 15, 2023
@francovenica francovenica moved this from In Progress to QA in progress in Web Squad Aug 15, 2023
@francovenica francovenica moved this from QA in progress to QA done in Web Squad Aug 15, 2023
@github-project-automation github-project-automation bot moved this from QA done to Done in Web Squad Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants