Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happens on SendNFT click when NFTs page was opened before new tx form #2506

Closed
liliya-soroka opened this issue Sep 14, 2023 · 0 comments · Fixed by #2527
Closed

Nothing happens on SendNFT click when NFTs page was opened before new tx form #2506

liliya-soroka opened this issue Sep 14, 2023 · 0 comments · Fixed by #2527
Assignees
Labels
bug Something isn't working

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Sep 14, 2023

Bug description

Nothing happens on SendNFT click when NFTs page was opened before new tx form

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: any

Steps to reproduce

  1. Open "NFT" tab of "Assets" page
  2. Click on "New transaction" (on left navigation menu)
  3. Click "Send NFT"
    Current result: User is not navigated to "NFT" tab (URL changes from https://app.safe.global/balances/nfts?safe=zksync:{address} to https://app.safe.global/balances/nfts?safe=zksync%3A{address}

Expected result

Before the tx flow redesign, "Send NFT" button was hidden in case NFTs page was opened.
From my point of view, the user should be send back to "Nfts" page , but it might be confusing.
The expected result should be discussed internally

Obtained result

Screenshots

https://drive.google.com/file/d/104nuatiShpmz9eKAcE7TrEft3Zn3Lre0/view

@liliya-soroka liliya-soroka added the bug Something isn't working label Sep 14, 2023
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Sep 14, 2023
@iamacook iamacook self-assigned this Sep 19, 2023
@iamacook iamacook moved this from New issues to Peer Review in Web Squad Sep 19, 2023
@iamacook iamacook moved this from Peer Review to Ready for QA in Web Squad Sep 22, 2023
@francovenica francovenica moved this from Ready for QA to QA done in Web Squad Sep 22, 2023
@github-project-automation github-project-automation bot moved this from QA done to Done in Web Squad Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants