Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a warning/prompt when nonce is above the latest nonce #2560

Closed
katspaugh opened this issue Sep 27, 2023 · 0 comments · Fixed by #2563 or #2625
Closed

Show a warning/prompt when nonce is above the latest nonce #2560

katspaugh opened this issue Sep 27, 2023 · 0 comments · Fixed by #2563 or #2625
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@katspaugh
Copy link
Member

katspaugh commented Sep 27, 2023 •
edited
Loading

Show a warning/confirmation request when the entered nonce is too high.

  • If the user has entered a nonce that's higher than the recommended nonce, show a warning.
  • Also, if the recommended nonce from the backend is too far ahead of the Safe nonce due to an unexpected bug, we should also warn the user
  • In both cases, do not let the tx be submitted w/o a confirmation.
@katspaugh katspaugh added the bug Something isn't working label Sep 27, 2023
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Sep 27, 2023
@katspaugh katspaugh moved this from New issues to Todo in Web Squad Sep 27, 2023
@katspaugh katspaugh added the major Major bug (to be solved in the next release) label Sep 27, 2023
@iamacook iamacook mentioned this issue Sep 28, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Web Squad Oct 2, 2023
@iamacook iamacook moved this from Done to Todo in Web Squad Oct 2, 2023
@iamacook iamacook reopened this Oct 2, 2023
@katspaugh katspaugh mentioned this issue Oct 12, 2023
Merged
@katspaugh katspaugh moved this from Todo to Peer Review in Web Squad Oct 12, 2023
@katspaugh katspaugh moved this from Peer Review to Ready for QA in Web Squad Oct 16, 2023
@liliya-soroka liliya-soroka moved this from Ready for QA to QA in progress in Web Squad Oct 16, 2023
@github-project-automation github-project-automation bot moved this from QA in progress to Done in Web Squad Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Web Squad
Archived in project
Milestone
No milestone
2 participants
@katspaugh @iamacook