fix: Anonymize safe address on gtm init #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3b4a736
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d4c5f95.web-core.pages.dev |
| Branch Preview URL: | https://anon-pathname.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
reviewed
Nov 3, 2022
| TagManager.initialize({ | ||
| gtmId: GOOGLE_TAG_MANAGER_ID, | ||
| ...GTM_ENVIRONMENT, | ||
| dataLayer: { | ||
| pageLocation: `${location.origin}${pagePath}`, |
There was a problem hiding this comment.
In my tests, router.pathname doesn't include our rewrites. We could pass it as an argument to gtmInit and then not need anonymise the pathname.
There was a problem hiding this comment.
Good idea! It works nicely although we have to exclude it from the dependency array but I think it should be fine since it is only needed on the initial load.
iamacook
reviewed
Nov 3, 2022
| @@ -19,7 +19,8 @@ const useGtm = () => { | |||
|
|
|||
| // Initialize GTM, or clear it if analytics is disabled | |||
| useEffect(() => { | |||
| isAnalyticsEnabled ? gtmInit() : gtmClear() | |||
| isAnalyticsEnabled ? gtmInit(router.pathname) : gtmClear() | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
Can you add a comment why we need to do this please.
src/utils/url.ts
Outdated
| @@ -5,7 +5,8 @@ const trimTrailingSlash = (url: string): string => { | |||
| const isSameUrl = (url1: string, url2: string): boolean => { | |||
| return trimTrailingSlash(url1) === trimTrailingSlash(url2) | |||
| } | |||
|
|
|||
| export const prefixedAddressRe = /[a-z0-9-]+\:0x[a-f0-9]{40}/i | |||
| export const addressRe = /0x[a-f0-9]{40}/i | |||
There was a problem hiding this comment.
This is not being used anymore.
iamacook
approved these changes
Nov 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1034
How this PR fixes it
Sets anonymized path and location in dataLayer when initializing GTM
How to test it
user_engagementevent with anonymized path and location valuesScreenshots