feat(safe-apps): Analytics refactor #1042
Conversation
…at/safe-apps-analysis
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deploying with
|
| Latest commit: |
c45a88d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ac8e201.web-core.pages.dev |
| Branch Preview URL: | https://feat-safe-apps-analysis.web-core.pages.dev |
| </main> | ||
| <> | ||
| <Head> | ||
| <title>Safe Apps – Share</title> |
There was a problem hiding this comment.
Perhaps we can include the app name in the title as a future enhancement 🤔
There was a problem hiding this comment.
yep, we sent the app name or url (if custom) here
| if (!isLoading && safeApp?.chainIds.length) { | ||
| const appName = backendApp ? backendApp.name : safeApp.url | ||
|
|
||
| trackSafeAppEvent(SAFE_APPS_EVENTS.SHARED_APP_LANDING, appName) |
There was a problem hiding this comment.
Do we really need 2 separate events for this? Can the chainid be included in the SHARED_APP_LANDING?
There was a problem hiding this comment.
yep, changed it. Does not make sense
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
What it solves
This PR add a refactor to the Safe Apps analytics current behavior as part of the analytics epic
How this PR fixes it
We are making changes to reflect the status described here
How to test it
We need to validate all the event actions described here are being sent
@JagoFigueroa the preference is validate this using GTM and GA4 tools. We can align on this
Analytics changes
We now are sending all the analytics from Safe Apps using the concrete
safeAppevent or the custompageview. Previously it was a combination of Safe App events and Safe Web Custom events withmetadatacategory. Is easier and less prone to errors to use only the Safe App event. We now have under thesafeAppevent two categories (safe-appsandsafe-apps-sdk)We now are sending the app name always in the
safeAppNamediimension. If the app belongs to the default list we send the name and if not the url (custom app). Previously the dimension was only being used for SDK events and we were sending the names in theeventLabelwith no clear consensus. Doing this, we know clearly if the app is known and we free a dimension (eventLabel) for include any other dataWe send
pageviewevents for the Safe Apps list and for the concrete app being loaded in order to generate reports as the time elapsed in Safe apps sections or apps