Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AddressInput identicon #2393

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix: AddressInput identicon #2393

merged 1 commit into from
Aug 14, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2378

How this PR fixes it

If a valid address is inputted, it should show an identicon instead of a placeholder.

Screenshots

Screenshot 2023-08-14 at 16 00 32

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Branch preview

✅ Deploy successful!

https://fix_address_input--walletweb.review-wallet-web.5afe.dev

@katspaugh katspaugh requested a review from usame-algan August 14, 2023 14:01
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member

Tested in Send Tokens flow and address book 👍

@katspaugh katspaugh merged commit 085aebc into dev Aug 14, 2023
@katspaugh katspaugh deleted the fix-address-input branch August 14, 2023 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon missing in edit address book entry
2 participants