Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e Test] WIP e2e batch transactions #2406

Merged
merged 4 commits into from
Aug 18, 2023
Merged

[e2e Test] WIP e2e batch transactions #2406

merged 4 commits into from
Aug 18, 2023

Conversation

francovenica
Copy link
Contributor

What it solves

Add e2e for the batch tx feature

How this PR fixes it

Tests:
Empty state
Add to batch button present in the tx form
Adding 2 tx in a batch
Swapping tx order
Checking the order in the tx form
Delete a tx from the batch

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@francovenica francovenica added the enhancement New feature or request label Aug 16, 2023
@francovenica francovenica self-assigned this Aug 16, 2023
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Branch preview

✅ Deploy successful!

https://feature_e2e_batch_tx--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor Author

Added the suggestions.
Kept the test of the swap with a skip so we can revisit later
Added the test that validates the order of the tx in the form

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@katspaugh katspaugh merged commit 1642675 into dev Aug 18, 2023
@katspaugh katspaugh deleted the feature-e2e-batch-tx branch August 18, 2023 07:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants