feat: add claim button to header #2472
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
src/hooks/useSafeTokenAllocation.ts
Outdated
| @@ -126,30 +142,26 @@ const fetchTokenBalance = async (chainId: string, safeAddress: string): Promise< | |||
| * The Safe token allocation is equal to the voting power. | |||
| * It is computed by adding all vested tokens - claimed tokens + token balance | |||
| */ | |||
| const useSafeTokenAllocation = (): [BigNumber | undefined, boolean] => { | |||
| export const useSafeTokenBalance = (allocationData?: Vesting[]): AsyncResult<BigNumber> => { | |||
There was a problem hiding this comment.
| export const useSafeTokenBalance = (allocationData?: Vesting[]): AsyncResult<BigNumber> => { | |
| export const useSafeVotingPower = (allocationData?: Vesting[]): AsyncResult<BigNumber> => { |
Should we rename it to useSafeVotingPower?
useSafeTokenBalance sounds to me as if it would just fetch the current balance in a hook.
There was a problem hiding this comment.
I've renamed it accordingly in ba34f38.
| return false | ||
| } | ||
|
|
||
| return !sep5Allocation.isRedeemed |
There was a problem hiding this comment.
Like this we would need to make a change once the deadline is reached.
I think also checking if the allocation is expired would fix that.
| return !sep5Allocation.isRedeemed | |
| return !sep5Allocation.isRedeemed && !sep5Allocation.isExpired |
There was a problem hiding this comment.
I've added the extra check in ba34f38.
|
My only issue is the position of the green dot. I think it should be on the right bottom corner of the widget instead of being in the middle: maybe something like this: The rest is fine: If the position of the green dot is not a problem for the rest of the team we can pass the ticket to done |
We discussed this and deemed it fine as is. |
What it solves
Implements claim button in header
How this PR fixes it
The token allocation element in the header now includes a "New allocation" button according to the designs. Clicking it will take you to the claiming app and, providing there is nothing to claim, it should not appear.
How to test it
Open a Safe with an allocation and observe the new button. Claiming should make it dissappear and opening a Safe without an allocation should not show it at all.
Clicking on the button should the following event: "Click on SEP5 allocation button".
Screenshots
Checklist