Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Dashboard] better layout for pending txs #2491

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2060

How this PR fixes it

Uses flex-box like in the BatchTxItem.

Screenshots

Screenshot 2023-09-05 at 11 00 15 Screenshot 2023-09-05 at 12 39 00

Checklist

  • I've tested the branch on mobile 📱

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Branch preview

✅ Deploy successful!

https://fix_dashboard--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

src/components/dashboard/PendingTxs/styles.module.css Outdated Show resolved Hide resolved
@francovenica
Copy link
Contributor

Looks good to me. I've checked in the safe provided in the initial ticket since it has tx with long names in it:
eth:0x5f9ee776B85f1aFF123f935C48C528D00a62B0ad

Before the fix: Desktop - Tablet - Phone
image
image
image

After:
image
image
image

@katspaugh katspaugh merged commit b7a26e9 into dev Sep 7, 2023
@katspaugh katspaugh deleted the fix-dashboard branch September 7, 2023 07:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS bug in pending txs Dashboard widget
3 participants