-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add push notification tracking #2500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://firebase_tracking--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Sep 8, 2023
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Outdated
Show resolved
Hide resolved
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Outdated
Show resolved
Hide resolved
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Outdated
Show resolved
Hide resolved
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Show resolved
Hide resolved
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Outdated
Show resolved
Hide resolved
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Outdated
Show resolved
Hide resolved
src/components/settings/PushNotifications/hooks/useNotificationTracking.ts
Outdated
Show resolved
Hide resolved
katspaugh
reviewed
Sep 8, 2023
katspaugh
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please merge once the main PR is reviewed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Adds cached tracking to push notifications
How this PR fixes it
Due to technical limitations and a desire to keep the service worker small, every notification that is shown/clicked increments a counter in a new
notifications-tracking-database
IndexedDB database. A tracking event is then dispatched for every count when the UI is next shown.How to test it
Checklist