Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of existing Cypress tests (P2) #2512

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Refactoring of existing Cypress tests (P2) #2512

merged 2 commits into from
Sep 15, 2023

Conversation

mike10ca
Copy link
Contributor

What it solves

  • Refactoring of existing Cypress tests

Resolves #2511

How this PR fixes it

  • Implement PO Model
  • General refactoring

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://cypress_tests_refactoring_p2--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@mike10ca
Refactoring of tests: create wallet, import/export, load safe, nfts, …
55af947 
…landing, pendig actions; general refactoring
@mike10ca mike10ca marked this pull request as ready for review September 15, 2023 14:47
@mike10ca mike10ca requested a review from katspaugh September 15, 2023 14:47
katspaugh
katspaugh approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katspaugh katspaugh merged commit d158e17 into dev Sep 15, 2023
@katspaugh katspaugh deleted the cypress-tests-refactoring-p2 branch September 15, 2023 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring of existing Cypress tests (P2)
2 participants
@mike10ca @katspaugh