-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Create Safe] Handle wallet connection #1087
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d534589
fix: Handle wallet connection when creating safe
usame-algan 69512c2
fix: Only watch threshold
usame-algan 8d706dd
refactor: Rename useSetCreationStep to useSyncSafeCreationStep
usame-algan c38be69
fix: Use formState.isValid
usame-algan 26f1fca
fix: Add tests for useSyncSafeCreationStep
usame-algan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
src/components/new-safe/CreateSafe/__tests__/useSyncSafeCreationStep.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { renderHook } from '@/tests/test-utils' | ||
import useSyncSafeCreationStep from '@/components/new-safe/CreateSafe/useSyncSafeCreationStep' | ||
import * as wallet from '@/hooks/wallets/useWallet' | ||
import * as localStorage from '@/services/local-storage/useLocalStorage' | ||
import type { ConnectedWallet } from '@/services/onboard' | ||
|
||
describe('useSyncSafeCreationStep', () => { | ||
beforeEach(() => { | ||
jest.clearAllMocks() | ||
}) | ||
|
||
it('should go to the first step if no wallet is connected', async () => { | ||
jest.spyOn(wallet, 'default').mockReturnValue(null) | ||
const mockSetStep = jest.fn() | ||
|
||
renderHook(() => useSyncSafeCreationStep(mockSetStep)) | ||
|
||
expect(mockSetStep).toHaveBeenCalledWith(0) | ||
}) | ||
|
||
it('should go to the fourth step if there is a pending safe', async () => { | ||
jest.spyOn(localStorage, 'default').mockReturnValue([{}, jest.fn()]) | ||
jest.spyOn(wallet, 'default').mockReturnValue({ address: '0x1' } as ConnectedWallet) | ||
const mockSetStep = jest.fn() | ||
|
||
renderHook(() => useSyncSafeCreationStep(mockSetStep)) | ||
|
||
expect(mockSetStep).toHaveBeenCalledWith(4) | ||
}) | ||
|
||
it('should not do anything if wallet is connected and there is no pending safe', async () => { | ||
jest.spyOn(localStorage, 'default').mockReturnValue([undefined, jest.fn()]) | ||
jest.spyOn(wallet, 'default').mockReturnValue({ address: '0x1' } as ConnectedWallet) | ||
const mockSetStep = jest.fn() | ||
|
||
renderHook(() => useSyncSafeCreationStep(mockSetStep)) | ||
|
||
expect(mockSetStep).not.toHaveBeenCalled() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { Alert, AlertTitle } from '@mui/material' | ||
import { useCurrentChain } from '@/hooks/useChains' | ||
|
||
const NetworkWarning = () => { | ||
const chain = useCurrentChain() | ||
|
||
if (!chain) return null | ||
|
||
return ( | ||
<Alert severity="info" sx={{ mt: 3 }}> | ||
<AlertTitle sx={{ fontWeight: 700 }}>Change your wallet network</AlertTitle> | ||
You are trying to create a Safe on {chain.chainName}. Make sure that your wallet is set to the same network. | ||
</Alert> | ||
) | ||
} | ||
|
||
export default NetworkWarning |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think even though it's quite trivial we should write a small test for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done