Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Systray icon support for Gnome 42+ #244

Closed
PixsaOJ opened this issue Jun 22, 2022 · 5 comments
Closed

Systray icon support for Gnome 42+ #244

PixsaOJ opened this issue Jun 22, 2022 · 5 comments
Assignees
Labels
suggestion TYPE: idea for new feature or improvements

Comments

@PixsaOJ
Copy link

PixsaOJ commented Jun 22, 2022

What would you like to add or change?:
I would like to have official support for Gnome 42 try icons.

Why do you and others need this?:
libappindicator was deprecated, the only way to show try icon is to install additional extension. This breaks UI flow and adds its own UI element. Not everyone might like this implementation/hacky fix.

Additional info

Currently, Portmaster uses Fyne.io systray module.

fyne-io/fyne#283

Here we see suggestion to use library: systray
image

It has support for both: old libappindicator and new ayanata.

The referenced issue is old. I do not know if Fyne.io already has ayanata implementation.

Original issue I created here: #240

Edit: make sure to do research. I might be wrong about this ayanata thing.

@PixsaOJ PixsaOJ added the suggestion TYPE: idea for new feature or improvements label Jun 22, 2022
@ghost ghost assigned dhaavi and ghost Jun 23, 2022
@dhaavi
Copy link
Member

dhaavi commented Jun 23, 2022

Hey @PixsaOJ, thanks for opening the suggestion!

I'm not sure if libappindicator even had support for the Gnome42 tray icons.

libappindicator is deprecated, and we switched over to the ayanata implementation - BUT not all distros had that so it started failing. We do not want to build and distribute different binaries for different distros, so we switched to https://github.com/fyne-io/systray, which uses the DBUS interface directly from Go, without and C dependencies.

I think the best way to move forward is to work on adding Gnome42 tray icon support to the https://github.com/fyne-io/systray library.

Do you know where the specs for integrating with the Gnome42 tray icon system is?

@PixsaOJ
Copy link
Author

PixsaOJ commented Jun 23, 2022 via email

@dhaavi
Copy link
Member

dhaavi commented Jun 23, 2022

I imagine some kind of try/catch function.

I've investigated that, but in this case this about a C import. Don't know of any way to try/catch that.

Can you give us some examples of apps that work well with your setup?
If you find the time, it would also be great if you could research how they do the tray icon.

@PixsaOJ
Copy link
Author

PixsaOJ commented Jun 23, 2022 via email

@Raphty
Copy link
Member

Raphty commented Mar 29, 2024

We are restructuring our co debase into a mono-repo where all Portmaster components will live happily together.
For this reason this issue had to be closed.

@Raphty Raphty closed this as completed Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
suggestion TYPE: idea for new feature or improvements
Projects
None yet
Development

No branches or pull requests

3 participants