Replies: 1 comment 1 reply
-
Yeah, this is probably a good idea as the submodule is a bit of a chore. I would not download the list directly at build time since requiring network to compile is probably worse. But since we have @teto-bot set up on a schedule to update the submodule anyway, we can reduce the tedium by committing the file directly to the repo as you suggest and have @teto-bot update it periodically via a PR. We just have to make sure to include the license info. Note that we already download the public suffix at runtime with the recommended URL, but we also provide a precompiled one in case the public suffix is not reachable at runtime. Incidentally it might be nice to allow users to configure whether the list should be updated automatically or not, and to tie it to a running |
Beta Was this translation helpful? Give feedback.
-
Status: Accepted
isahc/.gitmodules
Lines 1 to 3 in 7163e8a
We make psl list a submodule three years ago. And I think it isn't worth it to introduce a git submodule a simple file.
publicsuffix/list
is licensed underMPL-2.0
, maybe we can embed the file directly in our repo with a clear license statement?We can download from https://publicsuffix.org/list/public_suffix_list.dat directly and validate it via it's etag in md5
This change will make our contributors happy for the first time they are trying to build isahc locally.
Besides, it's the recommend way as described in
public_suffix_list.dat
:cc @sagebind for comments.
Updates: Implemented in #408
Beta Was this translation helpful? Give feedback.
All reactions