Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the code for explore(obj) and explore() ? #12

Open
nthiery opened this issue Jul 22, 2018 · 4 comments
Open

Decouple the code for explore(obj) and explore() ? #12

nthiery opened this issue Jul 22, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request long term

Comments

@nthiery
Copy link
Contributor

nthiery commented Jul 22, 2018

The layout of the widgets for explore() and explore(obj) may become relatively different. Maybe we would want to split the code accordingly into two classes? Or is there a lot shared between the two?

@zerline
Copy link
Collaborator

zerline commented Jul 23, 2018

I agree, they may become rather different. There is still a lot to be shared: the display structure (unless we want it more different than now). And a few methods. A possibility could be to write a base class (XYZExplorer), then make 2 classes ObjectExplorer and ExplorerIndex (or any names) inherit from the base class.

@nthiery
Copy link
Contributor Author

nthiery commented Jul 23, 2018 via email

@zerline
Copy link
Collaborator

zerline commented Jul 24, 2018

It will be ..

@zerline zerline self-assigned this Jul 24, 2018
@zerline zerline added the enhancement New feature or request label Nov 15, 2018
@zerline
Copy link
Collaborator

zerline commented Mar 11, 2020

With a4c38c5, we decided to use the same display for now.
In the future, we would like to display, for a catalog, all its values as a table with name, icon, description and args box in case args are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request long term
Projects
None yet
Development

No branches or pull requests

2 participants