Fix compilation and runtime errors on Fedora 42

Author: tobiasdiez

.devcontainer/onCreate-meson.sh

@@ -16,6 +16,7 @@ eval $(build/bin/sage-print-system-package-command $SYSTEM --yes --ignore-missin
 
 # Disable build isolation following the advice of https://mesonbuild.com/meson-python/how-to-guides/editable-installs.html#build-dependencies
 # Install build dependencies manually as workaround for https://github.com/astral-sh/uv/issues/1516
+uv venv
 uv pip install \
     meson-python \
     "cypari2 >=2.2.1" \
@@ -25,4 +26,4 @@ uv pip install \
     memory_allocator \
     "numpy >=1.25" \
     jinja2
-uv sync --frozen --no-build-isolation-package=sagemath
+uv sync --frozen --inexact --no-build-isolation-package=sagemath

.github/workflows/ci.yml

@@ -69,7 +69,7 @@ jobs:
             "numpy >=1.25" \
             jinja2
 
-          uv sync --frozen --no-build-isolation-package=sagemath
+          uv sync --frozen --inexact --no-build-isolation-package=sagemath
 
       - name: Test
         run: |

pyproject.toml

@@ -49,7 +49,8 @@ dependencies = [
     'fpylll >=0.5.9',
     'ptyprocess > 0.5',
     # TODO: Remove this once the migration to meson is complete
-    'pkgconfig'
+    'pkgconfig',
+    'traitlets',
 ]
 dynamic = ["version"]
 license = {text = "GNU General Public License (GPL) v2 or later"}
@@ -205,3 +206,7 @@ ignore = [
 "all.py" = [
   "F401", # Unused import - these files are by definition collections of imports.
 ]
+
+[tool.uv]
+# Don't use build isolation for sage (it's incompatible with meson-python's editable install)
+no-build-isolation-package = ["sagemath"]

src/sage/graphs/graph.py

@@ -9480,7 +9480,7 @@ def bipartite_double(self, extended=False):
     from sage.graphs.weakly_chordal import is_long_hole_free, is_long_antihole_free, is_weakly_chordal
     from sage.graphs.asteroidal_triples import is_asteroidal_triple_free
     chromatic_polynomial = LazyImport('sage.graphs.chrompoly', 'chromatic_polynomial', at_startup=True)
-    from sage.graphs.graph_decompositions.rankwidth import rank_decomposition
+    rank_decomposition = LazyImport('sage.graphs.graph_decompositions.rankwidth', 'rank_decomposition', at_startup=True)
     from sage.graphs.graph_decompositions.tree_decomposition import treewidth
     from sage.graphs.graph_decompositions.vertex_separation import pathwidth
     from sage.graphs.graph_decompositions.tree_decomposition import treelength

src/sage/libs/ecl.pxd

@@ -89,7 +89,6 @@ cdef extern from "ecl/ecl.h":
     # Type predicates returning a C boolean
 
     bint bint_floatp "floatp" (cl_object x)
-    bint bint_numberp "ecl_numberp" (cl_object x)
     bint bint_eql "ecl_eql"(cl_object x, cl_object y)
     bint bint_equal "ecl_equal"(cl_object x, cl_object y)
     bint bint_equalp "ecl_equalp"(cl_object x, cl_object y)

src/sage/libs/ecl.pyx

@@ -34,8 +34,6 @@ cdef bint bint_symbolp(cl_object obj) noexcept:
 # these type predicates are only provided in "cl_*" form, so we wrap them
 # with the proper type cast.
 
-cdef bint bint_numberp(cl_object obj) noexcept:
-    return not(cl_numberp(obj) == ECL_NIL)
 cdef bint bint_integerp(cl_object obj) noexcept:
     return not(cl_integerp(obj) == ECL_NIL)
 cdef bint bint_rationalp(cl_object obj) noexcept:

subprojects/ecl.wrap

@@ -1,5 +1,5 @@
 [wrap-git]
 url = https://gitlab.com/embeddable-common-lisp/ecl.git
-revision = 24.5.10
+revision = develop
 depth = 1
 patch_directory = ecl