-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in integral_points (for elliptic curves over Q) #10152
Comments
comment:1
More data points: with E=2082a1 and using the S_integral_points function, with S=[2] or S=[3] the coefficient bound used is 11, while with S=[2,3] it is 13 and the extra integral point is found! Clearly, a priori, enlarging S should not ever reduce this bound, so something is wrong there. This shows that both integral_points() and S_integral_points() need fixing. |
comment:2
Here is a list of curves and integral x-coordinates not found by Sage, as provided by John Cannon. It is not necessarily complete, but is a minimal set of test cases for any patch fixing this.
|
comment:5
See #10973. The patch there finds the missing integral points mentioned here. |
comment:6
This is fixed by #10973. It should be closed as duplicate. |
Work Issues: sd32 |
Changed work issues from sd32 to none |
Changed keywords from integral points to integral points sd32 |
Reviewer: William Stein |
but
so we miss one point. Note that this point is 13*P where P is the generator, and our code computes the bound to be 12.
John Cannon is sending me a complete list of integral points for all curves in the Cremona database, computed using Magma, using some recent enhancements. Previously I had checked that Sage and Magma agreed to conductor 10000, so their enhancements must also fix bugs.
CC: @sagetrac-gagansekhon @sagetrac-weigandt
Component: elliptic curves
Keywords: integral points sd32
Reviewer: William Stein
Issue created by migration from https://trac.sagemath.org/ticket/10152
The text was updated successfully, but these errors were encountered: