Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of non-commutative k-Schur functions in the nilCoxeter algebra #11290

Closed
sagetrac-chrisjamesberg mannequin opened this issue May 4, 2011 · 17 comments
Closed

Comments

@sagetrac-chrisjamesberg
Copy link
Mannequin

sagetrac-chrisjamesberg mannequin commented May 4, 2011

Implementation of the nilCoxeter algebra for all Weyl Groups. In affine type 'A' it computes the k-schur functions in non-commutative variables.

Apply: attachment: trac_11290-nilCoxeter-final.patch

CC: @sagetrac-sage-combinat @anneschilling

Component: combinatorics

Keywords: kSchur, nilCoxeter algebra, days30

Author: Chris Berg, Anne Schilling

Reviewer: Jason Bandlow, Franco Saliola

Merged: sage-4.7.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11290

@sagetrac-chrisjamesberg sagetrac-chrisjamesberg mannequin added this to the sage-4.7.1 milestone May 4, 2011
@sagetrac-chrisjamesberg
Copy link
Mannequin Author

sagetrac-chrisjamesberg mannequin commented May 4, 2011

Changed keywords from kSchur, nilCoxeter algebra to kSchur, nilCoxeter algebra, days30

@anneschilling
Copy link

Changed author from Chris Berg to Chris Berg, Anne Schilling

@anneschilling

This comment has been minimized.

@anneschilling anneschilling changed the title Implementation of non-commutative k-Schur functions in the nil-Coxeter algebra. Implementation of non-commutative k-Schur functions in the nilCoxeter algebra May 4, 2011
@sagetrac-chrisjamesberg

This comment has been minimized.

@jbandlow
Copy link

jbandlow commented May 6, 2011

Reviewer: Jason Bandlow

@jbandlow
Copy link

jbandlow commented May 6, 2011

comment:5

This iteration looks good to me, Chris. Positive review!

@sagetrac-chrisjamesberg

This comment has been minimized.

@sagetrac-chrisjamesberg

This comment has been minimized.

@saliola
Copy link

saliola commented May 7, 2011

comment:8

There is a problem with the patch: applies cleanly, builds fine, but I got an import error on startup:

ImportError: No module named nil_coxeter_algebra

Chris, perhaps you forgot to add your nil_coxeter_algebra.py file to the patch?

@sagetrac-chrisjamesberg
Copy link
Mannequin Author

sagetrac-chrisjamesberg mannequin commented May 7, 2011

Attachment: trac_11290-nilCoxeter-cb.patch.gz

Enjoy Jason!

@saliola
Copy link

saliola commented May 7, 2011

comment:9

For the latest patch, all doctests pass, and coverage is at 100%.

But, I think there will be a problem building the documentation unless the following line in algebra.rst is updated appropriately:

../sage/algebras/nil_coxeter

@anneschilling
Copy link

comment:10

Thanks Franco for the report! This should be fixed now.

Chris, I also modified the documentation of the k_schur_noncommutative_variables, since it now only works for affine type A, but the documentation had not been updated.

I set it back to positive review since all issues were fixed.

Anne

Apply: trac_11290-nilCoxeter-final.patch

@anneschilling
Copy link

Attachment: trac_11290-nilCoxeter-final.patch.gz

@anneschilling
Copy link

comment:11

I fixed one more unnecessary import from WeylGroups in the patch and posted the new version.

Anne

Apply: trac_11290-nilCoxeter-final.patch

@saliola
Copy link

saliola commented May 8, 2011

Changed reviewer from Jason Bandlow to Jason Bandlow, Franco Saliola

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

Merged: sage-4.7.1.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants