-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of non-commutative k-Schur functions in the nilCoxeter algebra #11290
Comments
Changed keywords from kSchur, nilCoxeter algebra to kSchur, nilCoxeter algebra, days30 |
Changed author from Chris Berg to Chris Berg, Anne Schilling |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reviewer: Jason Bandlow |
comment:5
This iteration looks good to me, Chris. Positive review! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:8
There is a problem with the patch: applies cleanly, builds fine, but I got an import error on startup:
Chris, perhaps you forgot to add your |
Attachment: trac_11290-nilCoxeter-cb.patch.gz Enjoy Jason! |
comment:9
For the latest patch, all doctests pass, and coverage is at 100%. But, I think there will be a problem building the documentation unless the following line in algebra.rst is updated appropriately:
|
comment:10
Thanks Franco for the report! This should be fixed now. Chris, I also modified the documentation of the k_schur_noncommutative_variables, since it now only works for affine type A, but the documentation had not been updated. I set it back to positive review since all issues were fixed. Anne Apply: trac_11290-nilCoxeter-final.patch |
Attachment: trac_11290-nilCoxeter-final.patch.gz |
comment:11
I fixed one more unnecessary import from WeylGroups in the patch and posted the new version. Anne Apply: trac_11290-nilCoxeter-final.patch |
Changed reviewer from Jason Bandlow to Jason Bandlow, Franco Saliola |
This comment has been minimized.
This comment has been minimized.
Merged: sage-4.7.1.alpha1 |
Implementation of the nilCoxeter algebra for all Weyl Groups. In affine type 'A' it computes the k-schur functions in non-commutative variables.
Apply: attachment: trac_11290-nilCoxeter-final.patch
CC: @sagetrac-sage-combinat @anneschilling
Component: combinatorics
Keywords: kSchur, nilCoxeter algebra, days30
Author: Chris Berg, Anne Schilling
Reviewer: Jason Bandlow, Franco Saliola
Merged: sage-4.7.1.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/11290
The text was updated successfully, but these errors were encountered: