Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dist directory from eclib spkg #11354

Closed
sagetrac-mariah mannequin opened this issue May 19, 2011 · 9 comments
Closed

remove dist directory from eclib spkg #11354

sagetrac-mariah mannequin opened this issue May 19, 2011 · 9 comments
Labels
c: packages: standard p: trivial / 5 t: enhancement
Milestone
sage-4.7.2

Comments

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 19, 2011

This is a subtask of #5903.

Apply http://sage.math.washington.edu/home/leif/Sage/spkgs/eclib-20100711.p0.spkg

Component: packages: standard

Keywords: sd32

Author: Mariah Lenox

Reviewer: William Stein

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11354
@sagetrac-mariah sagetrac-mariah mannequin added this to the sage-4.7.2 milestone May 19, 2011
@sagetrac-mariah
Copy link
Mannequin Author

sagetrac-mariah mannequin commented May 19, 2011

Attachment: eclib-20100711.p0.diff.gz

diff for review purposes only

@sagetrac-mariah
Copy link
Mannequin Author

sagetrac-mariah mannequin commented May 19, 2011

Author: Mariah Lenox

@sagetrac-mariah

This comment has been minimized.

Sign in to view
@williamstein
Copy link
Contributor

comment:2

looks good to me.

Note that the SPKG.txt doesn't have an entry for this, which one would typically add. I've always considered adding lines in SPKG.txt and in the HG repo both to be redundant though.

@williamstein
Copy link
Contributor

Reviewer: William Stein

@williamstein
Copy link
Contributor

Changed keywords from none to sd32

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 12, 2011

Merged: sage-4.7.2.alpha3

@nexttime nexttime mannequin removed the s: positive review label Sep 12, 2011
@nexttime nexttime mannequin closed this as completed Sep 12, 2011
@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 23, 2011

comment:6

New spkg lacks a corresponding changelog entry. 8/

Corrected spkg at new location.

@nexttime

This comment has been minimized.

Sign in to view
@JohnCremona JohnCremona mentioned this issue May 6, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: trivial / 5 t: enhancement
Projects
None yet
Milestone
sage-4.7.2
Development

No branches or pull requests
1 participant
@williamstein