-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
01 sequence or east-north sequence for partitions #11410
Comments
comment:1
suggestions for the name welcome |
comment:2
Helloooooo !!! Some remarks/questions :
Nathann |
comment:3
Apply trac_11410-zero_one_sequence_partitions-pod.v2.patch Here is patch with some corrections. |
This comment has been minimized.
This comment has been minimized.
Author: Paul-Olivier Dehaye |
Reviewer: Frédéric Chapoton, Nathann Cohen |
comment:6
Apply trac_11410-zero_one_sequence_partitions-pod.v2.patch |
comment:7
Could you add
to Thanks, Travis |
comment:8
When I have used these I have called them path sequences or Maya diagrams. Andrew |
comment:9
Here is a new patch, rebased on 5.7.beta3. In my opinion, there remains one problem : the choice of the name. If nobody comes with a better one, with references, then I think the ticket is good to go, if the light turns green. |
comment:10
Apply trac_11410-zero_one_sequence_partitions-pod.v2.patch |
comment:11
May I suggest implementing a similar back-and-forth conversion for skew partitions and biwords of 0's and 1's? Of course, one could take the Comét code of the inner rim and the outer rim, but then one would have to fumble around with their offsets to make them match, so an implementation in the library would be preferred. Curiosity question: What is a difference between a normal and an "indirect" doctest? |
comment:12
Replying to @darijgr:
It's for functions/methods that aren't explicitly called in the doctest. For example As for the patch, the A math/documentation note, these also arise from affine permutations and have connections to Finally could you rebase this on the (soon to be completed) #13605? I'll do the final review if you rebase it as soon as #13605 is done. Promise. Thank you, Travis |
Dependencies: #13605 |
comment:14
This fails to apply for me over #13605:
|
comment:15
Well, I have not yet rebased the patch, so the hunks are expected. I do not know when I will find time do do that. |
comment:16
Here is a rebased. Still missing things about names.. Apply trac_11410-zero_one_sequence_partitions-pod.v2.patch |
comment:18
Hey Frederic, I've uploaded a review patch which adds some more info to the documentation. Everything else looks good to me. If you agree with my changes, you can set this to positive review. Thanks, Travis |
Changed reviewer from Frédéric Chapoton, Nathann Cohen to Frédéric Chapoton, Nathann Cohen, Travis Scrimshaw |
This comment has been minimized.
This comment has been minimized.
comment:19
For patchbot: Apply: trac_11410-zero_one_sequence_partitions-pod.v2.patch, trac_11410-zero_one_sequence_partitions-review-ts.patch |
comment:20
maybe you could use the very new arxiv role
as introduced in #14011 Otherwise, things look good. I am just waiting for the green light from the bot. |
comment:21
Attachment: trac_11410-zero_one_sequence_partitions-review-ts.patch.gz Done. For patchbot: Apply: trac_11410-zero_one_sequence_partitions-pod.v2.patch, trac_11410-zero_one_sequence_partitions-review-ts.patch |
comment:22
The patchbot was blue (due to #13605). I gave it a kick. For patchbot: Apply: trac_11410-zero_one_sequence_partitions-pod.v2.patch, trac_11410-zero_one_sequence_partitions-review-ts.patch |
comment:23
Replying to @fchapoton:
Since the patchbot gives the go-ahead (when it doesn't timeout), I'm setting this to positive review. |
Merged: sage-5.8.beta4 |
Adds a method to the partition class that returns the 01 sequence of the partition (the sequence of north or east steps taken along the boundary of the partition). Since this is really an biinfinite sequence starting with 0000000 and ending with 11111111, this should return a a finite list of 0s and 1s, starting for any (non-empty) partition with a 1 and ending with a 0.
Apply:
Depends on #13605
CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: partition
Author: Paul-Olivier Dehaye
Reviewer: Frédéric Chapoton, Nathann Cohen, Travis Scrimshaw
Merged: sage-5.8.beta4
Issue created by migration from https://trac.sagemath.org/ticket/11410
The text was updated successfully, but these errors were encountered: