Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPIR: Use proper ABI name on Linux PPC64 #11964

Closed
ghost opened this issue Oct 31, 2011 · 9 comments
Closed

MPIR: Use proper ABI name on Linux PPC64 #11964

ghost opened this issue Oct 31, 2011 · 9 comments
Assignees
@nexttime
Labels
c: packages: standard p: minor / 4 t: bug
Milestone
sage-4.8

Comments

@ghost
Copy link

ghost commented Oct 31, 2011

This is a follow-up to #11896, where we introduced setting ABI also on Linux unless it is already set.

On 64-bit PowerPC Linux, this has to be ABI=mode64 instead of ABI=64.

New spkg: http://sage.math.washington.edu/home/leif/Sage/spkgs/mpir-2.1.3.p7.spkg

md5sum: cf8ce66fd5e5fcec58d3b0f596f76cb5

CC: @kiwifb @jhpalmieri

Component: packages: standard

Keywords: PowerPC64 mode32 mode64 64-bit

Author: Leif Leonhardy

Reviewer: John Palmieri

Merged: sage-4.8.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/11964
Repository owner added this to the sage-4.8 milestone Oct 31, 2011
Repository owner added c: packages: standard labels Oct 31, 2011
@ghost ghost assigned nexttime Oct 31, 2011
@nexttime
Copy link
Mannequin

nexttime mannequin commented Oct 31, 2011

Attachment: mpir-2.1.3.p6-p7.diff.gz

Diff between the p6 (from #11896) and the p7. For reference / review only.

@nexttime

This comment has been minimized.

Sign in to view
@nexttime
Copy link
Mannequin

nexttime mannequin commented Oct 31, 2011

Author: Leif Leonhardy

@nexttime nexttime mannequin added the s: needs review label Oct 31, 2011
@kiwifb
Copy link
Member

kiwifb commented Oct 31, 2011

comment:2

I will try to give a spin shortly.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:3

The patch makes sense and this builds on the skynet machine silius. François, I'm setting this to positive review, but if you disagree or want more time to look at it, please switch it back.

@jdemeyer
Copy link

jdemeyer commented Nov 3, 2011

Merged: sage-4.7.3.alpha0

@jdemeyer jdemeyer closed this as completed Nov 3, 2011
@jdemeyer
Copy link

jdemeyer commented Nov 3, 2011

Milestone sage-4.7.3 deleted

@jdemeyer jdemeyer removed this from the sage-4.8 milestone Nov 3, 2011
@jdemeyer
Copy link

jdemeyer commented Nov 3, 2011

Changed merged from sage-4.7.3.alpha0 to sage-4.8.alpha0

@jdemeyer jdemeyer added this to the sage-4.8 milestone Nov 3, 2011
@vbraun vbraun mentioned this issue Apr 29, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nexttime nexttime

Labels
c: packages: standard p: minor / 4 t: bug
Projects
None yet
Milestone
sage-4.8
Development

No branches or pull requests
4 participants
@ghost @kiwifb @jhpalmieri @jdemeyer