-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of weak k-tableaux #12250
Comments
Changed keywords from tableaux to tableaux, days49 |
Changed dependencies from #11742 to none |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
Strong tableaux was moved into ticket #14776 |
Reviewer: Mike Zabrocki, Anne Schilling |
This comment has been minimized.
This comment has been minimized.
Dependencies: #14519 |
comment:9
Hey Anne and Mike, Thank you both for your work on this. However there are a few things I've noticed while glancing over the patch:
Ack, that ended up being a longer list than I expected... Best, Travis |
Changed author from Anne Schilling, Mike Zabrocki to Anne Schilling |
Changed reviewer from Mike Zabrocki, Anne Schilling to Mike Zabrocki |
comment:11
Hi Travis and Mike, Thank you for your review comments. I incorporated them all, except for the input of the inner shape yet and the comments below:
We discussed coercing during design discussions at Sage Days 49 and currently decided against it. For now, it is easy to go between the various representations with the representation method. If we really need this feature, we can always add coercion later.
This is what Nicolas suggested to me, so I will leave it as is. Best, Anne |
Changed reviewer from Mike Zabrocki to Mike Zabrocki, Travis Scrimshaw |
comment:13
Hi Mike, Thanks for your review patch! I incorporated the changes. The new version now take as input
where shape is either a shape or a tuple of shapes in the skew case. I hope everything looks ok now! Anne |
comment:15
Hi Mike, The updated patch incorporated all changes we discussed (by e-mail). It
The semistandard checks and pretty printing rely on #14101, so I put this as a dependency. Best, Anne |
comment:16
Hi Mike, I just posted a new version which incorporates your two doc review patches and fixes the bug in weights. Anne |
comment:17
Fixed two more little issues that Mike found (spurious import of Tableau and innter_shape -> inner_shape). Anne |
comment:19
I'm happy and all tests pass. |
comment:20
Replying to @zabrocki:
Great, thank you for the review! I just made height_of_restriced_subword a private method. Nothing else changed. Anne |
comment:21
I reaffirm positive review. -Mike |
Attachment: trac_12250-ktableaux-as.patch.gz |
Merged: sage-5.12.beta5 |
comment:27
See #15444 for a follow-up on the k-charge implementation. |
This patch implements a new class of weak k-tableaux. It also removes white spaces from core.py.
The methods on k-charge were contributed by Nate Gallup and Avi Dalal during Sage Days 49 in Orsay.
Depends on #14519
Depends on #14101
Depends on #7983
Depends on #14772
Depends on #13589
Depends on #14907
Depends on #10630
Depends on #14143
Depends on #14015
Depends on #14516
CC: @sagetrac-sage-combinat @sagetrac-npgallup
Component: combinatorics
Keywords: tableaux, days49
Author: Anne Schilling
Reviewer: Mike Zabrocki, Travis Scrimshaw
Merged: sage-5.12.beta5
Issue created by migration from https://trac.sagemath.org/ticket/12250
The text was updated successfully, but these errors were encountered: