Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sage/graphs/graph_decompositions/rankwidth/ #12684

Closed
mwhansen opened this issue Mar 17, 2012 · 10 comments
Closed

Rename sage/graphs/graph_decompositions/rankwidth/ #12684

mwhansen opened this issue Mar 17, 2012 · 10 comments

Comments

@mwhansen
Copy link
Contributor

Introduced in #11754, this currently causes problems with #12659 as there is a \_\_init\_\_.py file in this directory and a corresponding extension module rankwidth.pyx.

Apply attachment: trac_12684.v2.patch.

CC: @jdemeyer @nathanncohen

Component: graph theory

Author: Mike Hansen

Reviewer: David Coudert

Merged: sage-5.0.beta11

Issue created by migration from https://trac.sagemath.org/ticket/12684

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:2

I have installed the patch on sage-5.0.beta8 and everything is in order (compilation, docbuild,...).

I give positive review.

David.

@mwhansen
Copy link
Contributor Author

Attachment: trac_12684.patch.gz

@jdemeyer
Copy link

Work Issues: MANIFEST.in

@jdemeyer
Copy link

comment:3

MANIFEST.in needs to be changed.

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member

Changed work issues from MANIFEST.in to none

@jhpalmieri
Copy link
Member

comment:4

Here's a new patch which just adds this change:

diff --git a/MANIFEST.in b/MANIFEST.in
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -6,8 +6,7 @@ include .hgignore .hg .hg/* .hgtags
 include bundle export install pull sage-push
 include module_list.py
 include spkg-delauto spkg-dist spkg-install
-include sage/graphs/graph_decompositions/rankwidth/README
-include sage/graphs/graph_decompositions/rankwidth/__init__.py
+include sage/graphs/graph_decompositions/rankwidth_c/README
 include sage/libs/gmp/__init__.py
 include sage/libs/linbox/matrix_rational_dense_linbox.cpp
 include sage/libs/polybori/__init__.py

@dcoudert
Copy link
Contributor

comment:5

Attachment: trac_12684.v2.patch.gz

I have installed version 2 of the patch on sage-5.0.beta9 and everything is in order (change in directory name, compilation, docbuild, long tests, functionality, etc.).

@jdemeyer
Copy link

Merged: sage-5.0.beta11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants