-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename sage/graphs/graph_decompositions/rankwidth/ #12684
Comments
Reviewer: David Coudert |
comment:2
I have installed the patch on sage-5.0.beta8 and everything is in order (compilation, docbuild,...). I give positive review. David. |
Attachment: trac_12684.patch.gz |
Work Issues: MANIFEST.in |
comment:3
MANIFEST.in needs to be changed. |
This comment has been minimized.
This comment has been minimized.
Changed work issues from MANIFEST.in to none |
comment:4
Here's a new patch which just adds this change: diff --git a/MANIFEST.in b/MANIFEST.in
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -6,8 +6,7 @@ include .hgignore .hg .hg/* .hgtags
include bundle export install pull sage-push
include module_list.py
include spkg-delauto spkg-dist spkg-install
-include sage/graphs/graph_decompositions/rankwidth/README
-include sage/graphs/graph_decompositions/rankwidth/__init__.py
+include sage/graphs/graph_decompositions/rankwidth_c/README
include sage/libs/gmp/__init__.py
include sage/libs/linbox/matrix_rational_dense_linbox.cpp
include sage/libs/polybori/__init__.py |
comment:5
Attachment: trac_12684.v2.patch.gz I have installed version 2 of the patch on sage-5.0.beta9 and everything is in order (change in directory name, compilation, docbuild, long tests, functionality, etc.). |
Merged: sage-5.0.beta11 |
Introduced in #11754, this currently causes problems with #12659 as there is a
\_\_init\_\_.py
file in this directory and a corresponding extension modulerankwidth.pyx
.Apply attachment: trac_12684.v2.patch.
CC: @jdemeyer @nathanncohen
Component: graph theory
Author: Mike Hansen
Reviewer: David Coudert
Merged: sage-5.0.beta11
Issue created by migration from https://trac.sagemath.org/ticket/12684
The text was updated successfully, but these errors were encountered: