Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let categories override the default implementation of __getitem__ in Parent #12956

Closed
nthiery opened this issue May 17, 2012 · 6 comments
Closed

Let categories override the default implementation of __getitem__ in Parent #12956

nthiery opened this issue May 17, 2012 · 6 comments
Assignees
@nthiery
Labels
c: categories p: major / 3 t: bug
Milestone
sage-5.1

Comments

@nthiery
Copy link
Contributor

nthiery commented May 17, 2012

Parent.getitem should be moved to FiniteEnumeratedSets (#12955). Alas, this is not yet possible since too many finite enumerated sets in Sage are not in the FiniteEnumeratedSets category (see #12957). In the meantime, this patch provides a workaround by asking Parent.getitem to first try to call __getitem__ on its super classes.

CC: @sagetrac-sage-combinat

Component: categories

Keywords: getitem

Author: Nicolas M. Thiéry

Reviewer: Franco Saliola

Merged: sage-5.1.beta1

Issue created by migration from https://trac.sagemath.org/ticket/12956
@nthiery nthiery added this to the sage-5.1 milestone May 17, 2012
@nthiery nthiery self-assigned this May 17, 2012
@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor Author

nthiery commented May 19, 2012

Attachment: trac_12956-parent_categories_getitem-nt.patch.gz

@nthiery
Copy link
Contributor Author

nthiery commented May 19, 2012

Changed keywords from none to getitem

@nthiery
Copy link
Contributor Author

nthiery commented May 19, 2012

Reviewer: Franco Saliola

@nthiery
Copy link
Contributor Author

nthiery commented May 19, 2012

comment:3

All tests pass on 5.0 + above patches with positive review in the Sage-Combinat queue.

Positive review on behalf of Franco sitting next to me.

@jdemeyer
Copy link

Merged: sage-5.1.beta1

This was referenced Oct 2, 2012
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nthiery nthiery

Labels
c: categories p: major / 3 t: bug
Projects
None yet
Milestone
sage-5.1
Development

No branches or pull requests
2 participants
@nthiery @jdemeyer