Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated doc tests for k-Schur function and affine Schubert calculus book #13911

Closed
anneschilling opened this issue Jan 4, 2013 · 8 comments
Closed

Comments

@anneschilling
Copy link

This patch updates the doctests in the book "k-Schur functions and affine Schubert calculus" written by Thomas Lam, Luc Lapointe, Jennifer Morse, Anne Schilling, Mark Shimozono, Mike Zabrocki. It uses features implemented in #13762.

Depends on #13762

CC: @sagetrac-sage-combinat @zabrocki

Component: combinatorics

Keywords: symmetric functions, book

Author: Anne Schilling, Mike Zabrocki

Reviewer: Mike Zabrocki, Anne Schilling

Merged: sage-5.6.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13911

@zabrocki
Copy link
Mannequin

zabrocki mannequin commented Jan 4, 2013

comment:2

Looks good. All tests pass.

@jdemeyer
Copy link

jdemeyer commented Jan 4, 2013

Changed dependencies from 13762 to #13762

@jdemeyer
Copy link

jdemeyer commented Jan 7, 2013

comment:4

This needs # long time additions at the following places (positive_review if you make these changes):

diff --git a/sage/tests/book_schilling_zabrocki_kschur_primer.py b/sage/tests/book_schilling_zabrocki_kschur_primer.py
--- a/sage/tests/book_schilling_zabrocki_kschur_primer.py
+++ b/sage/tests/book_schilling_zabrocki_kschur_primer.py
@@ -568,7 +568,7 @@
     sage: ks3z = Sym.kschur(3,t=z4)
     sage: ks3 = Sym.kschur(3,t=1)
     sage: p = Sym.p()
-    sage: p(ks3z[2, 2, 2, 2, 2, 2, 2, 2])
+    sage: p(ks3z[2, 2, 2, 2, 2, 2, 2, 2])  # long time (17s on sage.math, 2013)
     1/12*p[4, 4, 4, 4] + 1/4*p[8, 8] + (-1/3)*p[12, 4]
     sage: p(ks3[2,2])
     1/12*p[1, 1, 1, 1] + 1/4*p[2, 2] + (-1/3)*p[3, 1]
@@ -577,7 +577,7 @@

 Sage example in ./kschurnotes/notes-mike-anne.tex, line 5405::

-    sage: ks3z[3, 3, 3, 3]*ks3z[2, 1]
+    sage: ks3z[3, 3, 3, 3]*ks3z[2, 1]  # long time (10s on sage.math, 2013)
     ks3[3, 3, 3, 3, 2, 1]

 Sage example in ./kschurnotes/notes-mike-anne.tex, line 5565::
@@ -585,7 +585,7 @@
     sage: Sym = SymmetricFunctions(QQ['t'].fraction_field())
     sage: Q3 = Sym.kBoundedQuotient(3)
     sage: dks = Q3.dual_k_Schur()
-    sage: dks[2,1,1]*dks[3,2,1]
+    sage: dks[2,1,1]*dks[3,2,1]  # long time (37s on sage.math, 2013)
     (t^7+t^6)*dks3[2, 1, 1, 1, 1, 1, 1, 1, 1] + (t^4+t^3+t^2)*dks3[2, 2, 2,
     1, 1, 1, 1] + (t^3+t^2)*dks3[2, 2, 2, 2, 1, 1] +
     (t^5+2*t^4+2*t^3+t^2)*dks3[2, 2, 2, 2, 2] + (t^5+2*t^4+t^3)*dks3[3, 1,

@anneschilling
Copy link
Author

Attachment: trac_13911-doctests.patch.gz

@anneschilling
Copy link
Author

comment:5

Ok, I marked them. What is the proper/easiest way to find tests that need to be marked long instead of going through by hand?

Anne

@jdemeyer
Copy link

jdemeyer commented Jan 8, 2013

comment:8

Replying to @anneschilling:

Ok, I marked them. What is the proper/easiest way to find tests that need to be marked long instead of going through by hand?

That's the problem, there isn't really a good way to do this. There are some plans to change this, see #12720.

But usually when you're writing doctests, you would first run it interactively inside Sage (to know at least what the correct answer is). Then you would notice if the answer isn't returned immediately.

@anneschilling
Copy link
Author

comment:9

Replying to @jdemeyer:

Replying to @anneschilling:

Ok, I marked them. What is the proper/easiest way to find tests that need to be marked long instead of going through by hand?

That's the problem, there isn't really a good way to do this. There are some plans to change this, see #12720.

But usually when you're writing doctests, you would first run it interactively inside Sage (to know at least what the correct answer is). Then you would notice if the answer isn't returned immediately.

Thanks for letting me know! In our case sagetex actually made the doctests from the latex source of the book. But I suppose when putting those into the book we could have taken notice which tests took a long time.

Anne

@jdemeyer
Copy link

jdemeyer commented Jan 9, 2013

Merged: sage-5.6.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants