Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Crystals of Generalized Young Walls #14130

Closed
bsalisbury1 opened this issue Feb 15, 2013 · 21 comments
Closed

Implement Crystals of Generalized Young Walls #14130

bsalisbury1 opened this issue Feb 15, 2013 · 21 comments

Comments

@bsalisbury1
Copy link

Implements the crystal B(\infty) and B(\lambda), for a highest weight \lambda, in terms of generalized Young walls in affine type A_n^{(1)}.


Apply attachment: trac_14130-gyw-bs.patch

Depends on #14052

CC: @tscrim @sagetrac-sage-combinat

Component: combinatorics

Keywords: crystal, generalized Young wall, days45

Author: Lucas David-Roesler, Ben Salisbury

Reviewer: Travis Scrimshaw, Anne Schilling

Merged: sage-5.8.beta3

Issue created by migration from https://trac.sagemath.org/ticket/14130

@tscrim
Copy link
Collaborator

tscrim commented Feb 15, 2013

comment:2

Looks good to me.

For patchbot:

Apply: trac_14130-gyw-bw.2.patch

@tscrim

This comment has been minimized.

@anneschilling
Copy link

comment:4

We discussed a couple more small changes that Ben is going to implement.

@bsalisbury1

This comment has been minimized.

@bsalisbury1
Copy link
Author

comment:5

For patchbot:

Apply: trac_14130-gyw-bs.patch

@bsalisbury1

This comment has been minimized.

@anneschilling
Copy link

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Anne Schilling

@tscrim
Copy link
Collaborator

tscrim commented Feb 17, 2013

comment:8

Hey Ben,

One small doc thing slipped past me in the new patch; on line 18, you have

    Does not work with :funct:`TensorProductOfCrystals`.

but the link should be :func:`TensorProductOfCrystals`. Could you repost the patch with this change please?

Thanks,

Travis

@jdemeyer

This comment has been minimized.

@bsalisbury1
Copy link
Author

comment:11

Made appropriate change.

Travis looked over the patch.

@jdemeyer
Copy link

Merged: sage-5.8.beta1

@jdemeyer
Copy link

Changed merged from sage-5.8.beta1 to none

@jdemeyer
Copy link

comment:13

The LaTeX PDF documentation fails to build with this patch.

@anneschilling
Copy link

comment:15

Hi Ben,

I just pushed some changes to your patch to the sage-combinat queue (since there were trailing white spaces). Please pull from there to get them .

Also, for the very last method "subcrystal" could you please add a description.

Other than that the patch looks good to me. Once you make the change and are happy with my changes, please upload on trac and set a positive review on my behalf!

Anne

@tscrim
Copy link
Collaborator

tscrim commented Feb 25, 2013

comment:16

Looks good to me too. Thanks.

@jdemeyer
Copy link

comment:17

The LaTeX PDF documentation still fails to build:

! Misplaced \omit.
\math@cr@@@ ...@ \@ne \add@amps \maxfields@ \omit
                                                  \kern -\alignsep@ \iftag@ ...
l.96848 \end{gather}

?
! Emergency stop.
\math@cr@@@ ...@ \@ne \add@amps \maxfields@ \omit
                                                  \kern -\alignsep@ \iftag@ ...
l.96848 \end{gather}

!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on combinat.log.

@jdemeyer
Copy link

Work Issues: docpdf

@bsalisbury1
Copy link
Author

Attachment: trac_14130-gyw-bs.patch.gz

@tscrim
Copy link
Collaborator

tscrim commented Feb 27, 2013

Changed work issues from docpdf to none

@tscrim
Copy link
Collaborator

tscrim commented Feb 27, 2013

comment:20

The problem was that the pdf docbuild did not like the align* environment inside of a .. MATH:: but the html build worked just fine with this. This has been fixed for sure now.

@jdemeyer
Copy link

jdemeyer commented Mar 4, 2013

Merged: sage-5.8.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants