Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of elementary crystals #14413

Closed
bsalisbury1 opened this issue Apr 4, 2013 · 13 comments
Closed

Implementation of elementary crystals #14413

bsalisbury1 opened this issue Apr 4, 2013 · 13 comments

Comments

@bsalisbury1
Copy link

Implements the crystals T_lambda, R_lambda, C, and B_i for all types.

Depends on #13735
Depends on #14402

CC: @sagetrac-sage-combinat @anneschilling @tscrim

Component: combinatorics

Keywords: crystal

Author: Ben Salisbury

Reviewer: Travis Scrimshaw

Merged: sage-5.11.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14413

@bsalisbury1

This comment has been minimized.

@bsalisbury1 bsalisbury1 modified the milestones: sage-5.9, sage-5.10 Apr 11, 2013
@tscrim
Copy link
Collaborator

tscrim commented Apr 19, 2013

comment:5

Thanks for your work on this Ben.

@tscrim
Copy link
Collaborator

tscrim commented Apr 19, 2013

Dependencies: #14402

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2013

comment:7

Hey Ben,

Could you reupload the version of the patch on the combinat queue? I had to make some minor tweaks due changes in #14402.

Thanks,

Travis

@bsalisbury1
Copy link
Author

comment:8

It's re-uploaded. Thanks, Travis and Anne, for reviewing and adjusting!

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2013

comment:9

Thanks Ben.

@tscrim tscrim added this to the sage-5.11 milestone Jun 1, 2013
@tscrim tscrim removed the pending label Jun 1, 2013
@anneschilling
Copy link

comment:10

Why does this patch import ../sage/combinat/crystals/kyoto_path_model into the documentation? That does not seem to exist.

So I set this back to needs work.

Best,

Anne

@anneschilling
Copy link

comment:12

In addition, I unfortunately get test failures:

sage -t elementary_crystals.py
**********************************************************************
File "elementary_crystals.py", line 335, in sage.combinat.crystals.elementary_crystals.TCrystal.Element._latex_
Failed example:
    latex(t)
Expected:
    {t_{\left(-1\right)e_{0} + \left(-3\right)e_{1} + \left(-3\right)e_{2} + \left(-3\right)e_{deltacheck}}}
Got:
    {t_{-e_{0} - 3e_{1} - 3e_{2} - 3e_{deltacheck}}}
**********************************************************************
File "elementary_crystals.py", line 563, in sage.combinat.crystals.elementary_crystals.RCrystal.Element._latex_
Failed example:
    latex(r)
Expected:
    {r_{e_{0} + \left(-1\right)e_{2}}}
Got:
    {r_{e_{0} - e_{2}}}
**********************************************************************

@bsalisbury1
Copy link
Author

comment:13

Attachment: trac_14413-elementary_crystals-bs.patch.gz

@bsalisbury1
Copy link
Author

comment:14

Thank you, Anne, for pointing this out, and thank you, Travis, for your help!

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2013

Changed dependencies from #14402 to #13735 #14402

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2013

comment:15

Failing doctests were due to #13735. Idk how I mistakenly put the kyoto_path_model into the rst file... Thanks for catching this Anne.

@jdemeyer
Copy link

Merged: sage-5.11.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants