-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formating of examples in doc/en/thematic_tutorials/lie/weyl_character_ring.rst #14678
Comments
This comment has been minimized.
This comment has been minimized.
comment:1
Attachment: trac_14678-clean_lie_tutorial-nt.patch.gz |
comment:2
In case the changes in the other file risk to create conflicts with existing tickets, I am fine droping them / having them moved to those other tickets. |
comment:3
Hey Nicolas, Looks good. While we are at it, I've also fixed the line continuations over to the new format in a review patch. Best, Travis |
comment:4
Oh, I thought I had done this as well. But maybe only in the original file. Thanks! |
comment:5
Just checked your patch, and I am happy with it. |
comment:6
Is that a positive review? |
comment:7
It's a positive review for your patch :-) I let you setup the positive review on the whole thing. |
Reviewer: Travis Scrimshaw |
comment:8
Done. Almost forgot to put my name as the reviewer. |
comment:9
This should be rebased to sage-5.9 or later. |
Dependencies: #14014 |
comment:11
Still doesn't apply for me, with or without #14014:
|
comment:12
Attachment: trac_14678-clean_lie_tutorial-review-ts.patch.gz The problem was that the patch on trac was (slightly) different than the patch in the combinat queue (by marking a test a long), which is what I based my review patch on. This was what was causing the conflict. Nicolas, I've updated both patches in the queue. |
Merged: sage-5.11.beta1 |
Fixes several ill indented examples in doc/en/thematic_tutorials/lie/weyl_character_ring.rst introduced by #7922.
While I was at it, I fixed the same things in the other files of the lie thematic tutorial, as well as missing spaces around "=", and replaced
.. link
by the now available and less invasive..linkall
. I also removed the "long time" on the f(n,k) example line 498 of weyl_character_ring.rst, since it only takes 0.22s now on my machine (probably thanks to #13391).Depends on #14014
CC: @dwbump @anneschilling
Component: combinatorics
Author: Nicolas M. Thiéry
Reviewer: Travis Scrimshaw
Merged: sage-5.11.beta1
Issue created by migration from https://trac.sagemath.org/ticket/14678
The text was updated successfully, but these errors were encountered: