fix _test_category for polynomial rings #15232

saraedum · 2013-09-26T23:48:41Z

Polynomial rings whose elements are not extension classes currently don't pass the TestSuite:

sage: K.<x> = FunctionField(QQ)
sage: R.<y> = K[]
sage: TestSuite(R).run()
  Failure in _test_category:
  Traceback (most recent call last):
    File "/dev/shm/sage/local/lib/python2.7/site-packages/sage/misc/sage_unittest.py", line 282, in run
      test_method(tester = tester)
    File "element.pyx", line 511, in sage.structure.element.Element._test_category (sage/structure/element.c:5084)
    File "/dev/shm/sage/local/lib/python/unittest/case.py", line 424, in assertTrue
      raise self.failureException(msg)
  AssertionError: False is not true
  ------------------------------------------------------------
  The following tests failed: _test_category
Failure in _test_elements
The following tests failed: _test_elements

The problem is that polynomials do not use element_class to construct their elements but a _polyonmial_class which does not use the ElementMethods of the category.

Component: categories

Keywords: sd59

Author: Julian Rueth

Branch/Commit: 83ab7c3

Reviewer: Vincent Delecroix, David Roe

Issue created by migration from https://trac.sagemath.org/ticket/15232

The text was updated successfully, but these errors were encountered:

saraedum · 2013-09-27T00:10:53Z

Branch: u/saraedum/ticket/15232

saraedum · 2013-09-27T00:11:52Z

Author: Julian Rueth

roed314 · 2014-01-03T09:57:27Z

Changed branch from u/saraedum/ticket/15232 to u/roed/ticket/15232

roed314 · 2014-01-03T09:57:27Z

Commit: 8c58b70

roed314 · 2014-01-03T09:57:27Z

comment:4

I've rebased this against sage-6.0 + #12555.

Last 10 new commits:

`8c58b70`	`Merge commit '901f95321554' into ticket/15232`
`aa65f59`	`Removed removed file from doc.`
`f338b7f`	`Fix wrong NOTE block.`
`fcf6ad2`	`Fix for comparison of padics.`
`5f00813`	`Fixes for "sage not defined".`
`89ef12d`	`Merge remote-tracking branch 'origin/develop' into ticket/12555`
`0e7c964`	`Fixed failing doctest (likely due to #15422).`
`7d7ff1f`	`Merge branch 'master' into public/padics/templates-12555`
`4b633ab`	`Fixes for some missing/duplicated chunks.`
`66e5746`	`From Trac patches: trac_12555-pdf_fix-ts.patch.`

sagetrac-git · 2014-01-04T03:37:08Z

Changed commit from 8c58b70 to 3eafd90

sagetrac-git · 2014-01-04T03:37:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3eafd90`	`Fixing some conflicts between Jeroen's and Julian's changes`

sagetrac-git · 2014-01-04T03:39:11Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Recent commits:


49fae49	`Fixing some conflicts between Jeroen's and Julian's changes`
8c58b70	`Merge commit '901f95321554' into ticket/15232`
901f953	`Added new base classes for p-adic polynomial elements`

sagetrac-git · 2014-01-04T03:39:11Z

Changed commit from 3eafd90 to 49fae49

sagetrac-git · 2014-01-08T03:37:23Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2f14211`	`Chage polynomial_padic to Cython for upcoming p-adic template ticket`

sagetrac-git · 2014-01-08T03:37:23Z

Changed commit from 49fae49 to 2f14211

fchapoton · 2014-03-07T16:14:16Z

comment:9

There are some failing doctests, see patchbot report.

saraedum · 2014-06-26T07:04:04Z

Changed branch from u/roed/ticket/15232 to u/saraedum/ticket/15232

saraedum · 2014-06-26T07:05:05Z

Changed keywords from none to sd59

saraedum · 2014-06-26T07:05:05Z

Changed commit from 2f14211 to 0cbaa10

saraedum · 2014-06-26T07:05:05Z

comment:12

I am not sure anymore what I tried to do at this ticket. The new branch seems to fix this issue with only very few changes.

New commits:

`0cbaa10`	`Use Element/element_class for polynomials which are not extension classes`

malb · 2014-06-28T00:25:01Z

comment:13

Patchbot reports doctest failures.

roed314 · 2015-11-05T01:30:45Z

comment:26

Looks good to me.

roed314 · 2015-11-05T01:30:45Z

Changed work issues from conflicts to none

roed314 · 2015-11-05T01:30:45Z

Changed reviewer from Vincent Delecroix to Vincent Delecroix, David Roe

sagetrac-git · 2015-11-05T01:42:32Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`af6987d`	`Merge branch 'develop' into t/15232/public/ticket/15232`

sagetrac-git · 2015-11-05T01:42:32Z

Changed commit from d89d7b8 to af6987d

roed314 · 2015-11-05T01:47:27Z

comment:28

Thanks.

vbraun · 2015-11-05T21:12:21Z

comment:29

sage -t --long src/doc/ja/tutorial/tour_coercion.rst
**********************************************************************
File "src/doc/ja/tutorial/tour_coercion.rst", line 44, in doc.ja.tutorial.tour_coercion
Failed example:
    type(a); type(b); type(c)
Expected:
    <type 'sage.rings.polynomial.polynomial_integer_dense_flint.Polynomial_integer_dense_flint'>
    <class 'sage.rings.polynomial.polynomial_element_generic.Polynomial_generic_sparse'>
    <type 'sage.rings.polynomial.polynomial_integer_dense_ntl.Polynomial_integer_dense_ntl'>
Got:
    <type 'sage.rings.polynomial.polynomial_integer_dense_flint.Polynomial_integer_dense_flint'>
    <class 'sage.rings.polynomial.polynomial_element_generic.PolynomialRing_integral_domain_with_category.element_class'>
    <type 'sage.rings.polynomial.polynomial_integer_dense_ntl.Polynomial_integer_dense_ntl'>
**********************************************************************
1 item had failures:
   1 of  72 in doc.ja.tutorial.tour_coercion
    [59 tests, 1 failure, 0.34 s]

sagetrac-git · 2015-11-19T19:19:49Z

Changed commit from af6987d to 791d0d5

sagetrac-git · 2015-11-19T19:19:49Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f966948`	`Merge branch 'develop' into t/15232/public/ticket/15232`
`791d0d5`	`Fix doctest which failed because of type name change`

saraedum · 2015-11-19T19:20:07Z

New commits:

`f966948`	`Merge branch 'develop' into t/15232/public/ticket/15232`
`791d0d5`	`Fix doctest which failed because of type name change`

New commits:

`f966948`	`Merge branch 'develop' into t/15232/public/ticket/15232`
`791d0d5`	`Fix doctest which failed because of type name change`

sagetrac-git · 2015-12-23T19:02:55Z

Changed commit from 791d0d5 to 83ab7c3

sagetrac-git · 2015-12-23T19:02:55Z

Branch pushed to git repo; I updated commit sha1. New commits:

`83ab7c3`	`Merge branch 'develop' into t/15232/public/ticket/15232`

roed314 · 2016-02-16T21:09:36Z

comment:33

Looks good.

vbraun · 2016-02-18T08:24:48Z

Changed branch from public/ticket/15232 to 83ab7c3

saraedum added this to the sage-6.1 milestone Sep 26, 2013

saraedum added c: categories labels Sep 26, 2013

saraedum added the s: needs review label Sep 27, 2013

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014

fchapoton added s: needs work and removed s: needs review labels Mar 7, 2014

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014

saraedum added s: needs review and removed s: needs work labels Jun 26, 2014

roed314 added s: positive review and removed s: needs work labels Nov 5, 2015

sagetrac-git mannequin added s: needs review and removed s: positive review labels Nov 5, 2015

roed314 added s: positive review and removed s: needs review labels Nov 5, 2015

vbraun added s: needs work and removed s: positive review labels Nov 5, 2015

saraedum added s: needs review and removed s: needs work labels Nov 19, 2015

roed314 added s: positive review and removed s: needs review labels Feb 16, 2016

vbraun removed the s: positive review label Feb 18, 2016

vbraun closed this as completed in 187eed0 Feb 18, 2016

This was referenced Dec 12, 2017

Classes for discrete valuations #15154

Closed

Refactor inheritance of padic polynomials and polyniomial rings #15190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix _test_category for polynomial rings #15232

fix _test_category for polynomial rings #15232

saraedum commented Sep 26, 2013

saraedum commented Sep 27, 2013

saraedum commented Sep 27, 2013

roed314 commented Jan 3, 2014

roed314 commented Jan 3, 2014

roed314 commented Jan 3, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 8, 2014

sagetrac-git mannequin commented Jan 8, 2014

fchapoton commented Mar 7, 2014

saraedum commented Jun 26, 2014

saraedum commented Jun 26, 2014

saraedum commented Jun 26, 2014

saraedum commented Jun 26, 2014

malb commented Jun 28, 2014

roed314 commented Nov 5, 2015

roed314 commented Nov 5, 2015

roed314 commented Nov 5, 2015

sagetrac-git mannequin commented Nov 5, 2015

sagetrac-git mannequin commented Nov 5, 2015

roed314 commented Nov 5, 2015

vbraun commented Nov 5, 2015

sagetrac-git mannequin commented Nov 19, 2015

sagetrac-git mannequin commented Nov 19, 2015

saraedum commented Nov 19, 2015

sagetrac-git mannequin commented Dec 23, 2015

sagetrac-git mannequin commented Dec 23, 2015

roed314 commented Feb 16, 2016

vbraun commented Feb 18, 2016

fix _test_category for polynomial rings #15232

fix _test_category for polynomial rings #15232

Comments

saraedum commented Sep 26, 2013

saraedum commented Sep 27, 2013

saraedum commented Sep 27, 2013

roed314 commented Jan 3, 2014

roed314 commented Jan 3, 2014

roed314 commented Jan 3, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 4, 2014

sagetrac-git mannequin commented Jan 8, 2014

sagetrac-git mannequin commented Jan 8, 2014

fchapoton commented Mar 7, 2014

saraedum commented Jun 26, 2014

saraedum commented Jun 26, 2014

saraedum commented Jun 26, 2014

saraedum commented Jun 26, 2014

malb commented Jun 28, 2014

roed314 commented Nov 5, 2015

roed314 commented Nov 5, 2015

roed314 commented Nov 5, 2015

sagetrac-git mannequin commented Nov 5, 2015

sagetrac-git mannequin commented Nov 5, 2015

roed314 commented Nov 5, 2015

vbraun commented Nov 5, 2015

sagetrac-git mannequin commented Nov 19, 2015

sagetrac-git mannequin commented Nov 19, 2015

saraedum commented Nov 19, 2015

sagetrac-git mannequin commented Dec 23, 2015

sagetrac-git mannequin commented Dec 23, 2015

roed314 commented Feb 16, 2016

vbraun commented Feb 18, 2016