Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from Arb) #17220

cheuberg · 2014-10-25T14:54:16Z

Wrap the acb_mat type for matrices over complex balls.

In this ticket, level 1 functionality of matrices is provided.

Depends on #19751

CC: @sagetrac-alina @fredrik-johansson @sagetrac-ktkohl @sagetrac-skropf @jdemeyer @mezzarobba

Component: numerical

Keywords: arb, acb_mat, complex balls, matrix

Author: Clemens Heuberger

Branch/Commit: 8983012

Reviewer: Marc Mezzarobba, Fredrik Johansson

Issue created by migration from https://trac.sagemath.org/ticket/17220

The text was updated successfully, but these errors were encountered:

cheuberg · 2014-10-25T14:58:06Z

Branch: u/cheuberg/matrix/acb_dense

cheuberg · 2014-10-25T14:58:06Z

Last 10 new commits:

`4a34322`	`remove real_arb from documentation as it is an optional package`
`eb8b584`	`Trac #17194: Fix typo in one doctest`
`a6cb2ca`	`Trac #17194: declare return types`
`55bdc8b`	`Trac #17194: mark all doctests in real_arb.pyx as "optional - arb"`
`4b9cded`	`Trac #17218: Minimal bindings for acb's in the optional arb package`
`65fa1e5`	`Trac #17218: rename attribute Acb.precision to Acb._precision_`
`b082b08`	`Trac #17218: remove unneeded variable prec`
`4279c8c`	`Trac #17218: Acb: Fix missing documentation of input parameters`
`222c3be`	`Trac #17218: import a few more functions from acb.h`
`116de7b`	`Trac #17220: Minimal bindings for acb_mat in the optional arb package`

cheuberg · 2014-10-25T14:58:06Z

Commit: 116de7b

cheuberg · 2015-02-06T09:33:38Z

comment:3

The modifications made in #17194 will have to be made here, too, once #17194 is in final form.

sagetrac-git · 2015-02-20T18:28:52Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`4e7ec46`	`Trac #17194: is_zero, is_nonzero, is_exact`
`9e26152`	`Trac #17194: Implement comparisons`
`1196b57`	`Trac #17194: Fix RealBallField._an_element_`
`195a6ee`	`Trac #17194: Fix two broken references`
`5166337`	`Trac #17218: Merge #17194`
`1b39b15`	`Trac #17218: rename module to complex_ball_acb`
`ceeb591`	`Trac #17218: Fix doctests after renaming modules`
`fa46546`	`Trac #17218: implement parent`
`2f7c032`	`Trac #17220: Merge #17218 branch due to incompatible changes`
`3b7cd32`	`Trac #17220: Fix code after merge; acb_mat_to_matrix takes CIF`

sagetrac-git · 2015-02-20T18:28:52Z

Changed commit from 116de7b to 3b7cd32

sagetrac-git · 2015-02-24T18:21:27Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f40aaef`	`Trac #17218: Change signature of acb_to_ComplexIntervalFieldElement`
`dacd766`	`Merge #17218 due to conflicting change in commit f40aaef`
`fda400e`	`Trac #17220: Fix code after merge`

sagetrac-git · 2015-02-24T18:21:27Z

Changed commit from 3b7cd32 to fda400e

sagetrac-git · 2015-02-28T08:12:36Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2efc505`	`Trac #17218: let ComplexBallField belong to Fields()`
`e1dd21a`	`Trac #17220: Merge #17218`
`06bcc68`	`Trac #17220: rename matrix_acb_dense to matrix_complex_ball_dense`
`68d673b`	`Trac #17220: acb_mat as Sage matrix --- Level 1 functionality`

sagetrac-git · 2015-02-28T08:12:36Z

Changed commit from fda400e to 68d673b

cheuberg · 2015-02-28T08:16:07Z

Changed keywords from arb, acb_mat, complex intervals, matrix to arb, acb_mat, complex balls, matrix

sagetrac-git · 2015-03-01T12:00:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`cbce806`	`Trac #17220: mark three doctests as optional - arb`

sagetrac-git · 2015-03-01T12:00:18Z

Changed commit from 68d673b to cbce806

sagetrac-git · 2015-04-17T06:28:14Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1e0608c`	`Merge tag '6.6.beta5' into rings/complex_interval_acb`
`ef6ae7b`	`Trac #17218: Fix doctests after merge of 6.6.beta5 (and therefore #17786)`
`87bbb16`	`Trac #17218: Fix indendations`
`0e3a82e`	`Trac #17218: Merge '6.7.beta1' due to merge conflict with #18145`
`1a8e8dc`	`Trac #17220: Merge branch #17218 due to merge conflict with #18145`

sagetrac-git · 2015-04-17T06:28:14Z

Changed commit from cbce806 to 1a8e8dc

sagetrac-git · 2015-05-24T17:50:45Z

Changed commit from 1a8e8dc to 1dd4c89

sagetrac-git · 2015-05-24T17:50:45Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8049ae3`	`Trac #17218: Merge 6.7.beta4 (necessitated by #17890)`
`4f3489b`	Trac #17218: Replace cdef _richcmp_c_impl by cpdef `_richcmp_` (cf. #17890)
`d671d83`	`Trac #17218: Call Element.__init__ directly`
`b559917`	`Trac #17218: rewrite comparison`
`b666ea2`	`Trac #17218: mark as experimental`
`556651a`	`Trac #17220: merge latest version of #17220`
`1dd4c89`	`Trac #17220: Adapt doctest to include FutureWarning`

mezzarobba · 2015-12-20T11:17:31Z

comment:37

Indeed: I don't know how I missed that while reviewing the ticket, but apparently one can in fact not provide a “level-1” implementation only, because neither Matrix nor Matrix_dense provides a default implementation of _multiply_classical (even though docs.py claims implementing it is optional)!

mezzarobba · 2015-12-20T13:00:18Z

Changed commit from c095ddd to 5b13456

mezzarobba · 2015-12-20T13:00:18Z

Changed branch from u/cheuberg/acb_mat to public/arb/acb_mat

mezzarobba · 2015-12-20T13:00:18Z

Changed dependencies from #18546, #19063, #19152 to #19751

mezzarobba · 2015-12-20T13:00:18Z

comment:38

Should be okay with #19751.

New commits:

`308ed3d`	`generic multiplication for dense matrices`
`e0a8669`	`Merge in branch 'genmatmult' (trac #19751)`
`5b13456`	`#17220 test that multiplication and other basic ops still work`

sagetrac-git · 2016-03-23T20:05:45Z

Changed commit from 5b13456 to 7762a79

sagetrac-git · 2016-03-23T20:05:45Z

Branch pushed to git repo; I updated commit sha1. New commits:

`19ace33`	`Merge branch 'develop' into acb_mat`
`7762a79`	`#17220 include signals.pxi instead of interrupt.pxi`

mezzarobba · 2016-04-06T08:46:53Z

comment:40

Just to clarify, I think this ticket is good to go if someone reviews the small changes I made in the last few commits (and the dependency, which is 10 lines of code).

fredrik-johansson · 2016-04-07T13:51:56Z

Changed reviewer from Marc Mezzarobba to Marc Mezzarobba, Fredrik Johansson

fredrik-johansson · 2016-04-07T13:51:56Z

comment:41

Nitpick: it is claimed that a matrix can have up to 2^{64}-1 rows or columns, but the limit is technically 2^{63}-1 since a signed integer is used (and in practice, much less, since that much memory couldn't be addressed).

Other than that, it looks ok to me.

sagetrac-git · 2016-04-07T14:33:54Z

Changed commit from 7762a79 to 8983012

sagetrac-git · 2016-04-07T14:33:54Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`8983012`	`#17220 fix minor inaccuracy in docstring`

mezzarobba · 2016-04-07T14:37:02Z

comment:43

Replying to @fredrik-johansson:

Nitpick: it is claimed that a matrix can have up to 2^{64}-1 rows or columns, but the limit is technically 2^{63}-1 since a signed integer is used (and in practice, much less, since that much memory couldn't be addressed).

Fixed (for a definition of 64-bit machines that goes a little bit beyond current architectures ;-))

Other than that, it looks ok to me.

Thanks!

vbraun · 2016-04-08T22:40:18Z

Changed branch from public/arb/acb_mat to 8983012

cheuberg added this to the sage-6.4 milestone Oct 25, 2014

cheuberg added c: numerical labels Oct 25, 2014

cheuberg added the s: needs review label Oct 25, 2014

cheuberg added s: needs work and removed s: needs review labels Feb 6, 2015

This comment has been minimized.

Sign in to view

cheuberg added s: needs review and removed s: needs work labels Feb 28, 2015

cheuberg modified the milestones: sage-6.4, sage-6.6 Feb 28, 2015

cheuberg changed the title ~~Minimal bindings for acb_mat in the optional arb package~~ Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from Arb) Feb 28, 2015

mezzarobba added the s: needs info label Dec 20, 2015

mezzarobba added s: needs work and removed s: needs info labels Dec 20, 2015

mezzarobba added s: needs review and removed s: needs work labels Dec 20, 2015

fredrik-johansson added s: positive review and removed s: needs review labels Apr 7, 2016

sagetrac-git mannequin added s: needs review and removed s: positive review labels Apr 7, 2016

mezzarobba added s: positive review and removed s: needs review labels Apr 7, 2016

vbraun removed the s: positive review label Apr 8, 2016

vbraun closed this as completed in ae82c08 Apr 8, 2016

This was referenced Dec 8, 2015

Fourier coefficients of the fluctuation of the output sum of a transducer #17222

Open

Plot fluctuations of the output sum of a transducer #17263

Open

mezzarobba mentioned this issue Apr 8, 2016

Implement a generic multiplication method for dense matrices #19751

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from Arb) #17220

Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from Arb) #17220

cheuberg commented Oct 25, 2014

cheuberg commented Oct 25, 2014

cheuberg commented Oct 25, 2014

cheuberg commented Oct 25, 2014

cheuberg commented Feb 6, 2015

sagetrac-git mannequin commented Feb 20, 2015

sagetrac-git mannequin commented Feb 20, 2015

sagetrac-git mannequin commented Feb 24, 2015

sagetrac-git mannequin commented Feb 24, 2015

sagetrac-git mannequin commented Feb 28, 2015

sagetrac-git mannequin commented Feb 28, 2015

cheuberg commented Feb 28, 2015

This comment has been minimized.

sagetrac-git mannequin commented Mar 1, 2015

sagetrac-git mannequin commented Mar 1, 2015

sagetrac-git mannequin commented Apr 17, 2015

sagetrac-git mannequin commented Apr 17, 2015

sagetrac-git mannequin commented May 24, 2015

sagetrac-git mannequin commented May 24, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

sagetrac-git mannequin commented Mar 23, 2016

sagetrac-git mannequin commented Mar 23, 2016

mezzarobba commented Apr 6, 2016

fredrik-johansson commented Apr 7, 2016

fredrik-johansson commented Apr 7, 2016

sagetrac-git mannequin commented Apr 7, 2016

sagetrac-git mannequin commented Apr 7, 2016

mezzarobba commented Apr 7, 2016

vbraun commented Apr 8, 2016

Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from Arb) #17220

Matrix_complex_ball_dense: Level 1 implementation (using acb_mat from Arb) #17220

Comments

cheuberg commented Oct 25, 2014

cheuberg commented Oct 25, 2014

cheuberg commented Oct 25, 2014

cheuberg commented Oct 25, 2014

cheuberg commented Feb 6, 2015

sagetrac-git mannequin commented Feb 20, 2015

sagetrac-git mannequin commented Feb 20, 2015

sagetrac-git mannequin commented Feb 24, 2015

sagetrac-git mannequin commented Feb 24, 2015

sagetrac-git mannequin commented Feb 28, 2015

sagetrac-git mannequin commented Feb 28, 2015

cheuberg commented Feb 28, 2015

This comment has been minimized.

sagetrac-git mannequin commented Mar 1, 2015

sagetrac-git mannequin commented Mar 1, 2015

sagetrac-git mannequin commented Apr 17, 2015

sagetrac-git mannequin commented Apr 17, 2015

sagetrac-git mannequin commented May 24, 2015

sagetrac-git mannequin commented May 24, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

mezzarobba commented Dec 20, 2015

sagetrac-git mannequin commented Mar 23, 2016

sagetrac-git mannequin commented Mar 23, 2016

mezzarobba commented Apr 6, 2016

fredrik-johansson commented Apr 7, 2016

fredrik-johansson commented Apr 7, 2016

sagetrac-git mannequin commented Apr 7, 2016

sagetrac-git mannequin commented Apr 7, 2016

mezzarobba commented Apr 7, 2016

vbraun commented Apr 8, 2016