Remove deprecated classes ChooseNK and SplitNK

[zabrocki]

Ticket #10534 deprecated classes ChooseNK and SplitNK and that ticket was merged in Sage 6.3. This ticket is to remove those functions.

Not to be merged before 10 August 2015

CC: @sagetrac-sage-combinat @hivert @videlec @fchapoton @tscrim

Component: combinatorics

Keywords: days65, deprecate

Author: Mike Zabrocki

Branch/Commit: fd5dbe2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/18674

[zabrocki]

Author: Mike Zabrocki

[zabrocki]

New commits:

63df8b7	removed most instances of choose_nk and split_nk, choose_nk.from_rank and choose_nk.rank seem to remain
5258e5e	saved the functions rank and from_rank in choose_nk.py
ec6c8c9	readded file choose_nk.py
462efd5	restore important lines

[zabrocki]

Commit: 462efd5

[zabrocki]

Branch: public/zabrocki/remove/ChooseNK/SplitNK/18674

[zabrocki]

comment:2

Question: Should I leave the line

    sage/combinat/choose_nk

in /src/doc/en/reference/combinat/module_list.rst? There are two functions rank and from_rank that are still in that file.

[jdemeyer]

comment:4

Sage 6.3 was released on 10 August 2014, so this cannot be merged before 10 August 2015.

[sagetrac-git]

Changed commit from 462efd5 to 7b35f55

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7b35f55

restore pickles

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

39e1b1d

Merge branch 'develop' into public/zabrocki/remove/ChooseNK/SplitNK/18674

[sagetrac-git]

Changed commit from 7b35f55 to 39e1b1d

[sagetrac-git]

Changed commit from 39e1b1d to 828df24

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

828df24

Merge remote-tracking branch 'origin/public/zabrocki/remove/ChooseNK/SplitNK/18674' into public/zabrocki/remove/ChooseNK/SplitNK/18674

[videlec]

comment:9

If you want a review, you should switch the status to needs review...

[sagetrac-git]

Changed commit from 828df24 to 97d0c13

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

97d0c13

remove a few references to choose_nk, move functions in choose_nk.py to combination.py

[zabrocki]

comment:11

I felt it necessary to handle a TODO in choose_nk.py before switching the status which suggested that the choose_nk.rank and choose_nk.from_rank functions should be moved. I put them in combination.py since they were being used there (they are also used in subsets.py). I would not expect that they are being used elsewhere, but I thought it was a good idea to deprecate them as functions in choose_nk.py.

[tscrim]

comment:12

You should also change doctest:1: to doctest:...:.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ebba4ec

following Travis's comment replace :1:

[sagetrac-git]

Changed commit from 97d0c13 to ebba4ec

[videlec]

comment:14

Plenty of doctest failures (see patchbot report)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fd5dbe2

change choose_nk to combination

[sagetrac-git]

Changed commit from ebba4ec to fd5dbe2

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:17

LGTM.

[vbraun]

Changed branch from public/zabrocki/remove/ChooseNK/SplitNK/18674 to fd5dbe2