-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elementary and special functions for complex balls #19082
Comments
Commit: |
Branch: u/mmezzarobba/19082-acb-funs |
Last 10 new commits:
|
comment:3
In hypergeometric(), you could check if one of the upper parameters (typo: "paramaters") is equal to 1, and remove it. I guess you could also wrap hypgeom_m for 1F1 in this function. On the other hand, maybe it's best to wait until I put a function for pFq in Arb that takes care of all such special cases... If you upgrade to Arb 2.7.0, you can add Bessel Y, Bessel I, polygamma, barnes_g, log_barnes_g, and some more hyperbolic functions of complex arguments. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
comment:6
Rebased, added one commit. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:14
Note that the branch appears to merge cleanly despite the red link, and to pass the testsuite despite the patchbot's report. |
comment:15
I get the same doctest errors as the patchbot under 6.10.beta7, perhaps the upgrade to arb 2.7 induced the problem. (No problems under 6.10.beta4 where this patch is based). Do the tests really pass for you when merging with 6.10.beta7? |
This comment has been minimized.
This comment has been minimized.
comment:20
it has to be rebased over 7.0, and I also don't see any explanation of what CBF is in the docs. Note that CBF occurs earlier on in the doc, and it's not mentioned that it's the same thing as |
Work Issues: rebase over 7.0, doc. CBF |
comment:21
you might just use |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:23
Thanks for your comments! Replying to @dimpase:
What do you mean? Unless I made a mistake while checking, the branch merges without conflict into 7.0.
Yes, that's similar to the situation with New commits:
|
comment:25
Replying to @mezzarobba:
I meant that I checked it out, instead of merging it into 7.0, and had to wait for 10 minutes for the re-builds to finish :-)
That's exactly what I meant, thanks! |
comment:26
Reviewer name missing |
Reviewer: Dima Pasechnik |
comment:28
Thanks for the review! |
Changed branch from u/mmezzarobba/19082-acb-funs to |
Wrap the elementary and special functions on complex balls provided by arb (as of arb 2.6; a few more functions were added since then). We typically wrap only the high-level versions with automatic algorithm choice, and provide no Python access to implementations variants.
Depends on #19063
Depends on #19152
Component: numerical
Keywords: arb
Work Issues: rebase over 7.0, doc. CBF
Author: Marc Mezzarobba
Branch/Commit:
3873da1
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/19082
The text was updated successfully, but these errors were encountered: