-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewriting introductory thematic tutorial on coding theory #19897
Comments
Commit: |
comment:2
I pushed my work, this is now open for review. As a note for the reviewer/interested reader:
|
Author: David Lucas |
comment:3
Replying to @sagetrac-dlucas:
See http://doc.sagemath.org/html/en/developer/coding_basics.html#testing-rest-documentation |
comment:5
Thank you! I put David |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
I moved the list of decoder types from the thematic tutorial to the doctstring of |
comment:8
Looks very good to me. Some minor issues.
Have you checked that this looks alright in the pdf output? I think you might have to escape Other than that, feel free to set this to "positive review" once you adressed the above. |
comment:11
Hello, Thank you for your comments! I fixed every issue you noticed. Before setting this ticket to positive review, can you please add you name to the list of reviewers? David |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
Hello again, I finally removed the table of decoder types, as this types are actually a bit more tricky to define than I thought... David |
Reviewer: Julian Rüth |
Changed branch from u/dlucas/introductory_thematic_tutorial to |
Changed reviewer from Julian Rüth to Julian Rueth |
Changed commit from |
comment:17
jdemeyer: Out of curiosity. Someone told me that it's fine to put umlauts and such things now. Is there a reason why I should use not use "ü"? So I know how to do this in the future… |
comment:18
Replying to @saraedum:
The only reason is that you're known as "Julian Rueth" now, so it's for consistency. |
comment:19
If you like to change to "Rüth", that's not a problem for me. But at least try to use "Rüth" consistently then. |
With all the recent work done on the coding theory library in Sage, the existing thematic tutorial on CT should be updated.
This tutorial has (imho) some problems:
This ticket proposes a complete rework of this tutorial, which, instead of listing methods and constructions, gives some clues on how to build generic linear codes and perform standard operations (encoding, decoding, adding errors in words) for people working on coding theory.
It also explains to the user how to find any method and construction he needs.
Furthermore, it keeps things simple and never goes into technical details, or advanced scientific notions, preferring in that case to redirect the interested reader to manual pages instead.
CC: @tscrim
Component: coding theory
Author: David Lucas
Branch:
12bf512
Reviewer: Julian Rueth
Issue created by migration from https://trac.sagemath.org/ticket/19897
The text was updated successfully, but these errors were encountered: