Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Linear code from parity-check matrix #19975

Closed
sagetrac-dlucas mannequin opened this issue Jan 27, 2016 · 9 comments
Closed

Improve Linear code from parity-check matrix #19975

sagetrac-dlucas mannequin opened this issue Jan 27, 2016 · 9 comments

Comments

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Jan 27, 2016

As #19930 introduces a new encoder which computes a generator matrix for codes defined from their parity check matrices, it would be nice to update codes.LinearCodeFromCheckMatrix.

It could be renamed, made a class, and thus use the encoder described above.

Depends on #19930

Component: coding theory

Issue created by migration from https://trac.sagemath.org/ticket/19975

@sagetrac-dlucas sagetrac-dlucas mannequin added this to the sage-7.1 milestone Jan 27, 2016
@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Jan 27, 2016

Dependencies: #19930

@osj1961
Copy link
Mannequin

osj1961 mannequin commented Aug 10, 2016

comment:2

Should the description for this ticket read "...computes a generator matrix for codes defined from their generator parity check matrices" ?

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Aug 10, 2016

comment:3

Replying to @osj1961:

Should the description for this ticket read "...computes a generator matrix for codes defined from their generator parity check matrices" ?

Yes, nice catch! I changed the description.

@sagetrac-dlucas

This comment has been minimized.

@sagetrac-dlucas sagetrac-dlucas mannequin modified the milestones: sage-7.1, sage-7.4 Aug 10, 2016
@sagetrac-danielaugot
Copy link
Mannequin

sagetrac-danielaugot mannequin commented Aug 25, 2016

comment:4

Hi David

Which encoder are you mentionning in the description of the ticket ?

Are you suggesting to use the encoder codes.encoders.LinearCodeParityCheckEncoder ?

This encoder is deprecated.

Daniel

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Aug 25, 2016

comment:5

Actually, the point was to use the ParityCheckEncoder to as a building brick
for some codes, instead of having LinearCodeFromCheckMatrix
But as you said, ParityCheckEncoder is deprecated, and #21165 deprecates LinearCodeFromCheckMatrix.

So, let's set this ticket to invalid/won't fix.

David

@sagetrac-dlucas sagetrac-dlucas mannequin removed this from the sage-7.4 milestone Aug 25, 2016
@johanrosenkilde
Copy link
Contributor

comment:6

on the way to closing

@johanrosenkilde
Copy link
Contributor

comment:7

closing as wont-fix

@embray
Copy link
Contributor

embray commented Jul 13, 2017

comment:8

Closing tickets in the sage-duplicate/invalid/wontfix module with positive_review (i.e. someone has confirmed they should be closed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants