Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential refactoring of the species code #20622

Closed
nthiery opened this issue May 18, 2016 · 12 comments
Closed

Potential refactoring of the species code #20622

nthiery opened this issue May 18, 2016 · 12 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented May 18, 2016

The branch attached to this ticket propose a refactoring of the species code by Jean-Baptiste Priez

See src/sage/combinat/species2.

CC: @tscrim @fchapoton

Component: combinatorics

Keywords: species, LazyPowerSeries

Branch/Commit: public/combinat/species-refactoring @ 4bdf1cb

Issue created by migration from https://trac.sagemath.org/ticket/20622

@nthiery nthiery added this to the sage-7.3 milestone May 18, 2016
@nthiery
Copy link
Contributor Author

nthiery commented May 18, 2016

Branch: public/combinat/species-refactoring

@nthiery
Copy link
Contributor Author

nthiery commented May 18, 2016

comment:2

This is the original branch https://github.com/sagemath/sagetrac-mirror/commits/u/elixyre/species, with additional comments we added while sitting side by side.


Last 10 new commits:

df98bafticket species : fix valuation of addition
2234aaeticket species: fix distributivity of product of cis
e1bb5edticket species: remove a print
28ad5ceticket species: fix product of formal power series
6eaa5d4ticket species: fix species (product of formal series)
2dfcd85ticket species: add cycles index series of endofunctions species
55aba79ticket species: fix some bug... (there is still some problem with ogs)
32a263bticket species: fix the valuation
dd86a8fMerge branch 'develop' into combinat/species
b38a5c0Added comments while discussing the code with Jean-Baptiste

@nthiery
Copy link
Contributor Author

nthiery commented May 18, 2016

Commit: b38a5c0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

85d9cf3Merge branch 'develop' into combinat/species

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2016

Changed commit from b38a5c0 to 85d9cf3

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor Author

nthiery commented May 18, 2016

New commits:

85d9cf3Merge branch 'develop' into combinat/species

New commits:

85d9cf3Merge branch 'develop' into combinat/species

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2020

Changed commit from 85d9cf3 to 4bdf1cb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

4bdf1cbMerge branch 'develop' into t/20622/public/combinat/species-refactoring

@mantepse
Copy link
Collaborator

Changed keywords from none to species, LazyPowerSeries

@mantepse
Copy link
Collaborator

comment:7

I think we can close this, since the new LazyPowerSeries code has been merged.

@mantepse mantepse removed this from the sage-7.3 milestone Oct 17, 2022
@tscrim
Copy link
Collaborator

tscrim commented Oct 28, 2022

comment:8

Possibly, but there might be some other refactoring independent of the power series stuff that could be desired. It would be good if there was a little bit more information in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants