Improve minimum_distance for linear codes

[sagetrac-dlucas]

The method minimum_distance (and related method min_wt_vec_gap) can be improved in several ways, by:

• rewriting its documentation
• changing some names
• adding explicit error messages when the user uses the Guava option without
  Guava installed on his system.

This ticket takes care of the above improvements.

Component: coding theory

Keywords: rd3

Author: David Lucas

Branch/Commit: 804d2f2

Reviewer: Julien Lavauzelle

Issue created by migration from https://trac.sagemath.org/ticket/20953

[sagetrac-dlucas]

Branch: u/dlucas/clean_minimum_distance

[sagetrac-dlucas]

Commit: f0e15e4

[sagetrac-dlucas]

comment:2

I pushed the branch, which contains the following changes:

• renamed min_wt_vec_gap as _minimum_weight_codeword, moved it inside AbstractLinearCode (was a global method) and made it a private method.
• Rewrote documentation of _minimum_weight_codeword and minimum_distance, removed useless doctests.
• Removed a useless variable, factored some code.
• Added a proper check when the user calls algorithm="guava". If the user does not have Guava installed, it will fail with a proper error message instead of some random GAP error.

This is open for review.

Best,

David

---

New commits:

b467744	Improved min_wt_vec_gap
a052919	Reworked minimum_distance
f0e15e4	Minor changes to the code

[sagetrac-dlucas]

Author: David Lucas

[sagetrac-ylchapuy]

comment:3

merge conflict

[jlavauzelle]

Changed branch from u/dlucas/clean_minimum_distance to u/jlavauzelle/clean_minimum_distance

[jlavauzelle]

Reviewer: Julien Lavauzelle

[jlavauzelle]

Changed commit from f0e15e4 to 804d2f2

[jlavauzelle]

comment:5

Hi David,

I merged what you've done previously and I checked that doctests pass. Everything seems ok to me. I give a positive review.

Julien

---

New commits:

da01272	Fixed merge conflict. Doctests pass.
804d2f2	Removed deprecation alias for min_wt_vec_gap

[jlavauzelle]

Changed keywords from none to rd3

[vbraun]

Changed branch from u/jlavauzelle/clean_minimum_distance to 804d2f2