Remove support for Parent.__init__(gens=...)

[jdemeyer]

Parent.__init__() takes a gens keyword argument, but it turns out that nothing in Sage actually uses this argument. So we simply remove it. Then we can also remove the _populate_generators_ method which is never actually called.

(see also the task ticket: #21380)

Depends on #21382

CC: @videlec @tscrim

Component: categories

Author: Jeroen Demeyer

Branch/Commit: 517808d

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/21385

[jdemeyer]

Branch: u/jdemeyer/ticket/21385

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

517808d

Remove support for Parent.__init__(gens=...)

[sagetrac-git]

Commit: 517808d

[mezzarobba]

comment:4

The changes look good to me, but shouldn't the feature in question first be deprecated, in case something outside Sage uses it? (To be clear, I personally think the deprecation policy is both too vague and much too strict for the level of quality and maturity of large parts of Sage. But Sage does have such a policy...)

[jdemeyer]

comment:5

Replying to @mezzarobba:

The changes look good to me, but shouldn't the feature in question first be deprecated, in case something outside Sage uses it?

I don't see the point of deprecation here because the gens do not work anyway. Currently, the gens are passed to _populate_generators_ which assigns a _generators attribute which is then never used.

So I am not removing any functionality, I am basically just removing dead code.

In any case, this ticket depends on #21382 which should be reviewed first.

[mezzarobba]

comment:6

Replying to @jdemeyer:

I don't see the point of deprecation here because the gens do not work anyway. Currently, the gens are passed to _populate_generators_ which assigns a _generators attribute which is then never used.

So I am not removing any functionality, I am basically just removing dead code.

Fine then. (I hadn't paid attention to the fact that Parent.__init__() also accepted **kwds, sorry.)

In any case, this ticket depends on #21382 which should be reviewed first.

Yes, I posted the comment here since it applied to the second commit, but I was actually waiting for your answer to set the first ticket to positive review :-).

[mezzarobba]

Reviewer: Marc Mezzarobba

[vbraun]

Changed branch from u/jdemeyer/ticket/21385 to 517808d