-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add src/README.txt and build/README.txt #21565
Comments
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
comment:2
Needs review. New commits that improve/expand these descriptions are, of course, welcome too. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Dima Pasechnik |
comment:5
looks good enough to me (I'm a bit unhappy about .txt suffix vs no such suffix in other READMEs, but OK). |
comment:6
Replying to @dimpase:
Is this a "positive review"?
Note the majority of our README files already has
|
comment:7
OK - was in hurry and did not notice that I didn't set it to positive review, sorry. |
Changed branch from u/mkoeppe/add_src_readme_txt_and_build_readme_txt to |
This ticket adds README files that explain the purpose of the
src
andbuild
directories.Also, src/setup.py sdist (#21516) is asking for a README, so we make it happy too.
CC: @vbraun @jdemeyer @embray @kiwifb @dimpase @fchapoton
Component: build
Author: Matthias Koeppe
Branch/Commit:
1b45e56
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/21565
The text was updated successfully, but these errors were encountered: