Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for __matmul__ in the coercion model #22760

Closed
jdemeyer opened this issue Apr 5, 2017 · 21 comments
Closed

Add support for __matmul__ in the coercion model #22760

jdemeyer opened this issue Apr 5, 2017 · 21 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@jdemeyer
Copy link

jdemeyer commented Apr 5, 2017

Python 3.5 added the infix matrix multiplication operator PEP 465.

This ticket adds support for it in the coercion model.

The infix matrix multiplication operator (@) could be used for matrix and tensor multiplication.

Follow-up: #30244

CC: @jpflori @embray @tscrim @egourgoulhon @mjungmath

Component: python3

Author: Jeroen Demeyer, Matthias Koeppe

Branch/Commit: d939b2c

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22760
@jdemeyer jdemeyer added this to the sage-8.0 milestone Apr 5, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Add support for __matmul__ in the coercion model Add support for __matmul__ in preparser and the coercion model Apr 5, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Add support for __matmul__ in preparser and the coercion model Add support for __matmul__ in the coercion model Apr 5, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Apr 5, 2017

Branch: u/jdemeyer/add_support_for___matmul___in_the_coercion_model

@jdemeyer
Copy link
Author

jdemeyer commented Apr 5, 2017

New commits:

4f62e6fAdd support for `__matmul__` in the coercion model

@jdemeyer
Copy link
Author

jdemeyer commented Apr 5, 2017

Commit: 4f62e6f

@fchapoton
Copy link
Contributor

comment:7

does not apply

@jdemeyer
Copy link
Author

comment:8

@fchapoton: do you actually care about this ticket? I don't plan to fix a ticket if nobody looks at it anyway.

@embray
Copy link
Contributor

embray commented Feb 23, 2018

comment:9

This will still be good to have eventually. I wonder if we could also backport matmul support to Python 2 in the Sage pre-parser...

@embray embray removed this from the sage-8.0 milestone Feb 23, 2018
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 28, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 28, 2020

Changed branch from u/jdemeyer/add_support_for___matmul___in_the_coercion_model to u/mkoeppe/add_support_for___matmul___in_the_coercion_model

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 28, 2020

Changed commit from 4f62e6f to ea74b6f

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 28, 2020

New commits:

ea74b6fAdd support for `__matmul__` in the coercion model

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

d939b2cUpdate doctests for py3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 28, 2020

Changed commit from ea74b6f to d939b2c

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 28, 2020

Changed author from Jeroen Demeyer to Jeroen Demeyer, Matthias Koeppe

@tscrim
Copy link
Collaborator

tscrim commented Jul 29, 2020

comment:17

We can now include this in. Yay.

@tscrim
Copy link
Collaborator

tscrim commented Jul 29, 2020

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 29, 2020

comment:18

Thank you!

@mkoeppe

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Aug 7, 2020

Changed branch from u/mkoeppe/add_support_for___matmul___in_the_coercion_model to d939b2c

@vbraun vbraun closed this as completed in e9c25be Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
6 participants
@embray @vbraun @tscrim @jdemeyer @fchapoton @mkoeppe