Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings involving debug.refine_category_hash_check #24270

Closed
jdemeyer opened this issue Nov 23, 2017 · 7 comments
Closed

Fix compiler warnings involving debug.refine_category_hash_check #24270

jdemeyer opened this issue Nov 23, 2017 · 7 comments
Labels
p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

My compiler is not able to prove that the value of debug.refine_category_hash_check does not change during the call Parent._refine_category_. This gives -Wmaybe-uninitialized warnings.

I am working regularly on this file and this warning is always distracting me.

CC: @tscrim

Component: misc

Author: Jeroen Demeyer

Branch/Commit: 8dfff41

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24270
@jdemeyer jdemeyer added this to the sage-8.1 milestone Nov 23, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/fix_compiler_warnings_involving_debug_refine_category_hash_check

@jdemeyer
Copy link
Author

Commit: 8dfff41

@jdemeyer
Copy link
Author

New commits:

8dfff41Fix compiler warnings involving debug.refine_category_hash_check

@jdemeyer

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented Dec 11, 2017

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Dec 11, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Dec 13, 2017

Changed branch from u/jdemeyer/fix_compiler_warnings_involving_debug_refine_category_hash_check to 8dfff41

@vbraun vbraun closed this as completed in e5cbdd8 Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer