Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests that discriminant() of number fields is Integer #24462

Closed
jdemeyer opened this issue Jan 3, 2018 · 10 comments
Closed

Add tests that discriminant() of number fields is Integer #24462

jdemeyer opened this issue Jan 3, 2018 · 10 comments
Labels
p: minor / 4 t: enhancement t: tests
Milestone
sage-9.8

Comments

@jdemeyer
Copy link

jdemeyer commented Jan 3, 2018

The absolute_discriminant() of any number field should be a Sage Integer. This is currently not properly doctested, leading to a subtle failure in #24247.

CC: @JohnCremona @loefflerd @tscrim

Component: doctest coverage

Author: Frédéric Chapoton

Branch/Commit: fd5f450

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24462
@jdemeyer jdemeyer added this to the sage-8.2 milestone Jan 3, 2018
@fchapoton
Copy link
Contributor

Branch: u/chapoton/24462

@fchapoton
Copy link
Contributor

Commit: 9c35f8d

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

New commits:

9c35f8dadd test for absolute disc of number fields

@fchapoton fchapoton modified the milestones: sage-8.2, sage-9.8 Oct 31, 2022
@fchapoton
Copy link
Contributor

comment:2

green bot, so please review ; should be an easy one

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 31, 2022

Changed commit from 9c35f8d to fd5f450

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

fd5f450fix the doc

@tscrim
Copy link
Collaborator

tscrim commented Oct 31, 2022

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 31, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from u/chapoton/24462 to fd5f450

@vbraun vbraun closed this as completed in 642f115 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: tests
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@vbraun @tscrim @jdemeyer @fchapoton