-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change string representation of RealField #24523
Comments
This comment has been minimized.
This comment has been minimized.
Dependencies: #24511 |
comment:3
I first changed |
Branch: u/rws/24523 |
Commit: |
Changed author from Vincent Delecroix to Vincent Delecroix, Ralf Stephan |
comment:6
Sorry to spoil the party, but what is wrong with "Real Field with XX bits of precision"? Doesn't the "XX bits of precision" imply already that it's floating point? I think that the shorter name Note that also balls and intervals are floating-point, so do you plan to use |
comment:7
And anyway, this kind of things has to be agreed on on sage-devel. |
comment:8
Replying to @jdemeyer:
The rationale is: not precise enough. The "Real Field with XX bits of precision" could equivalently be used for intervals and balls. The standard terms in the literature are "floating-point arithmetic", "ball arithmetic" and "interval arithmetic". |
comment:9
This already accumulates merge conflicts en masse. |
This comment has been minimized.
This comment has been minimized.
comment:11
NOT to be merged: just testing what patchbots have to say... New commits:
|
Changed branch from u/rws/24523 to u/vdelecroix/24523 |
This comment has been minimized.
This comment has been minimized.
Changed dependencies from #24511 to none |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:48
Do we have a followup for |
comment:49
rebase please |
It was asked on the sage-devel discussion whether people have an opinion. Replying to [ticket:24523 ticket description]:
+1 from me |
comment:55
I wonder a bit about the changes in |
comment:56
Replying to @mjungmath:
Yes |
comment:57
rebase |
comment:58
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
comment:59
Setting a new milestone for this ticket based on a cursory review. |
We change the string representation of
RealField(XXX)
fromto
The reason for this change is that "Real Field" is not precise enough. Beyond floating-point, "Real Field" could equivalently be used for fixed-point, intervals and balls. The standard terms in the literature are "floating-point arithmetic", "fixed-point arithmetic", "ball arithmetic" and "interval arithmetic", see eg
This ticket is part of a the refactorization #24457 that intends to clean computations involving the different kinds of real numbers.
The git branch was obtained by running the following command in
$SAGE_ROOT/src
Tests work fine except for doctests that involves an output with a linebreak such as
(from
src/sage/tests/french_book/polynomes.py
line 218). These can also be handled using multiline sed replacementAs part of this ticket, the printf percentage syntax has been changed to the newer Python 3 standard
format
syntax (see comment:22) in all real field representations.Related discussion on sage-devel.
Component: basic arithmetic
Author: Vincent Delecroix, Ralf Stephan, Michael Jung
Branch/Commit: u/gh-mjungmath/24523 @
7f7d902
Reviewer: Vincent Klein, Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/24523
The text was updated successfully, but these errors were encountered: