Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DESTDIR support for python2/python3 #25043

Closed
embray opened this issue Mar 27, 2018 · 8 comments
Closed

Add DESTDIR support for python2/python3 #25043

embray opened this issue Mar 27, 2018 · 8 comments
Labels
c: build c: python3 p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@embray
Copy link
Contributor

embray commented Mar 27, 2018

Implements #24024 for python2 and python3.

Depends on #24599
Depends on #25039
Depends on #23733

Component: build

Keywords: destdir python2 python3

Author: Erik Bray

Branch/Commit: eca6471

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/25043
@embray embray added this to the sage-8.2 milestone Mar 27, 2018
@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

comment:2

(already merges without conflict with #23733)

@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

Changed dependencies from #24599, #25039 to #24599, #25039, #23733

@embray embray modified the milestones: sage-8.2, sage-8.3 Apr 26, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2018

Changed commit from 2c0b902 to eca6471

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

18c8d3bupdate python2/python3 to use sage-dist-helpers and support DESTDIR install
eca6471update package versions for buildbot

@saraedum
Copy link
Member

comment:5

feel free to set this to positive review if you have verified that it actually works.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@embray
Copy link
Contributor Author

embray commented Jul 18, 2018

comment:7

I believe this issue can reasonably be addressed for Sage 8.4.

@embray embray modified the milestones: sage-8.3, sage-8.4 Jul 18, 2018
@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/embray/build/destdir-python to eca6471

@vbraun vbraun closed this as completed in cf218b0 Aug 5, 2018
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@saraedum @embray @vbraun