Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DESTDIR support for nauty #25086

Closed
embray opened this issue Apr 3, 2018 · 5 comments
Closed

Add DESTDIR support for nauty #25086

embray opened this issue Apr 3, 2018 · 5 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@embray
Copy link
Contributor

embray commented Apr 3, 2018

Here the use of sdh_configure is not really necessary, but I use it for the built-in error handling.

Depends on #25039

Component: build

Keywords: destdir nauty

Author: Erik Bray

Branch/Commit: 216dd65

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/25086
@embray embray added this to the sage-8.2 milestone Apr 3, 2018
@saraedum
Copy link
Member

saraedum commented Apr 3, 2018

Reviewer: Julian Rüth

@embray embray modified the milestones: sage-8.2, sage-8.3 Apr 26, 2018
@vbraun
Copy link
Member

vbraun commented May 17, 2018

comment:4

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2018

Changed commit from 2975282 to 216dd65

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b0b38c2Adds a new sdh_install helper function:
852cb5ffix bug in handling of the -T flag--it was as if it was always set
5f7cd30fix bug that can occur in repeated invocations of sdh_install in the same script
daa37d5various minor review comments
0f848c3sdh_install_files -> sdh_install in error messages
216dd65Add DESTDIR support for nauty

@vbraun
Copy link
Member

vbraun commented May 20, 2018

Changed branch from u/embray/build/destdir-nauty to 216dd65

@vbraun vbraun closed this as completed in df30ddb May 20, 2018
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@saraedum @embray @vbraun