Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postive review] Sage 2.10.4.rc0: server/notebook/interact.py is broken due to #2530 #2538

Closed
sagetrac-mabshoff mannequin opened this issue Mar 16, 2008 · 4 comments
Closed

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 16, 2008

sage-2.10.4.rc0$ ./sage -t -long devel/sage/sage/server/notebook/interact.py
sage -t -long devel/sage-main/sage/server/notebook/interact.py
**********************************************************************
File "interact.py", line 1641:
    sage: selector([1,2,7], default=2).default()
Expected:
    2
Got:
    1
**********************************************************************
1 items had failures:
   1 of   1 in __main__.example_70
***Test Failed*** 1 failures.
For whitespace errors, see the file .doctest_interact.py
         [2.9 s]
exit code: 256

----------------------------------------------------------------------
The following tests failed:

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/2538

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-2.10.4 milestone Mar 16, 2008
@williamstein
Copy link
Contributor

comment:1

The new output, i.e., 1 is definitely now correct. Feel free to
make this change and close this ticket.

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Mar 16, 2008

Attachment: trac_2538.patch.gz

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Sage 2.10.4.rc0: server/notebook/interact.py is broken due to #2530 [needs trivial review] Sage 2.10.4.rc0: server/notebook/interact.py is broken due to #2530 Mar 16, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin assigned sagetrac-mabshoff and unassigned williamstein Mar 16, 2008
@mwhansen
Copy link
Contributor

comment:3

Looks okay to me.

@mwhansen mwhansen changed the title [needs trivial review] Sage 2.10.4.rc0: server/notebook/interact.py is broken due to #2530 [postive review] Sage 2.10.4.rc0: server/notebook/interact.py is broken due to #2530 Mar 16, 2008
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented Mar 16, 2008

comment:4

Merged in Sage 2.10.4.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 16, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants