printing bug with list_function()

[craigcitro]

This causes a bug when printing:

show([Matrix(ZZ,3,range(9)), Matrix(ZZ,3,range(9))])

Notice the extra ",". A list of one element doesn't have the same problem.

Component: graphics

Issue created by migration from https://trac.sagemath.org/ticket/2584

[jasongrout]

comment:1

The bug is in the latex function:

sage: latex([Matrix(ZZ,3,range(9)), Matrix(ZZ,3,range(9))])
\begin{array}{l}[\left(\begin{array}{rrr}
0 & 1 & 2 \\
3 & 4 & 5 \\
6 & 7 & 8
\end{array}\right),\\
\left(\begin{array}{rrr}
0 & 1 & 2 \\
3 & 4 & 5 \\
6 & 7 & 8
\end{array}\right)],\\
\end{array}

[jasongrout]

comment:2

Actually, the bug is in the list_function in latex.py in the case where the list string is too long. I'll post a patch momentarily.

[jasongrout]

Attachment: list-print-extra-comma.patch.gz

[jasongrout]

comment:3

I believe the above patch works, but I'm still building 2.10.4, so I haven't tested it yet.

[jasongrout]

comment:4

The patch fixes the problem.

[sagetrac-mabshoff]

comment:5

Replying to @jasongrout:

The patch fixes the problem.

While the patch looks like the fix to this problem shouldn't we also add a doctest that verifies that the bug has been fixed? Not to be pedantic ... well, I am :=)

Great job Jason.

Cheers,

Michael

[mwhansen]

Attachment: 2584.patch.gz

[mwhansen]

comment:6

I added some doctests; only the last patch should be applied. Positive review from me.

[sagetrac-mabshoff]

comment:7

Merged 2584.patch in Sage 2.11.alpha0 - thanks Mike for the doctest.

[jasongrout]

comment:8

Thanks, Mike for adding the doctests. The reason I didn't add doctests to test this fix was that the bug was only manifest in the notebook (in EMBEDDED_MODE). However, I should have gone ahead and added doctests for the basic functionality anyway, even if they didn't test that the bug in question is fixed, just to get the doctest score up and do my part towards the 3.0 goals :)