Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[with 2-line patch, positive review] subgroup of a permutation group is so slow it's silly #2587

Closed
rlmill mannequin opened this issue Mar 18, 2008 · 2 comments
Closed

[with 2-line patch, positive review] subgroup of a permutation group is so slow it's silly #2587

rlmill mannequin opened this issue Mar 18, 2008 · 2 comments
Assignees
@wdjoyner
Labels
c: group theory p: major / 3 t: bug
Milestone
sage-2.11

Comments

@rlmill
Copy link
Mannequin

rlmill mannequin commented Mar 18, 2008

The setup:

sage: C = QuadraticResidueCode(7, GF(2))
sage: G = C.permutation_automorphism_group()
sage: G.order()
168

Before:

sage: time SG = G.subgroup(list(G.gens()[:3]))
CPU times: user 0.86 s, sys: 0.34 s, total: 1.20 s
Wall time: 1.24

After:

sage: time SG = G.subgroup(list(G.gens()[:3]))
CPU times: user 0.00 s, sys: 0.00 s, total: 0.00 s
Wall time: 0.00

Component: group theory

Issue created by migration from https://trac.sagemath.org/ticket/2587
@rlmill rlmill mannequin added this to the sage-2.11 milestone Mar 18, 2008
@rlmill rlmill mannequin added c: group theory labels Mar 18, 2008
@rlmill rlmill mannequin assigned wdjoyner Mar 18, 2008
@mwhansen
Copy link
Contributor

comment:1

Attachment: 2587-subgroups-are-slow.patch.gz

This looks good and works for me.

@mwhansen mwhansen changed the title [with 2-line patch, needs review] subgroup of a permutation group is so slow it's silly [with 2-line patch, positive review] subgroup of a permutation group is so slow it's silly Mar 18, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 19, 2008

comment:2

Merged in Sage 2.11.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 19, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdjoyner wdjoyner

Labels
c: group theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.11
Development

No branches or pull requests
2 participants
@wdjoyner @mwhansen